Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg-full: enable libvo-amrwbenc #37432

Merged
merged 2 commits into from Apr 17, 2018
Merged

ffmpeg-full: enable libvo-amrwbenc #37432

merged 2 commits into from Apr 17, 2018

Conversation

Esteth
Copy link
Contributor

@Esteth Esteth commented Mar 20, 2018 •
edited

Motivation for this change

This enables ffmpeg to use the newly introduced vo-amrwbenc package to encode Adaptive Multi-Rate Wideband audio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Esteth Esteth changed the title ffmpeg-full | enable libvo-amrwbenc ffmpeg-full: enable libvo-amrwbenc Mar 20, 2018
@matthewbauer matthewbauer merged commit 4d3cec0 into NixOS:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Esteth @matthewbauer @GrahamcOfBorg