Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tablib: fix build #37247

Merged
merged 1 commit into from Mar 17, 2018
Merged

pythonPackages.tablib: fix build #37247

merged 1 commit into from Mar 17, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 17, 2018 •
edited

Motivation for this change

openpyxl v5 broke tablib: https://github.com/kennethreitz/tablib/issues/324

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner March 17, 2018 13:25
@Ma27
Copy link
Member Author

Ma27 commented Mar 17, 2018

starting nox-review to check possile further breackage

@dotlambda
Copy link
Member

Did you try applying https://github.com/kennethreitz/tablib/pull/296 instead of reverting the openpyxl update?

@Ma27
Copy link
Member Author

Ma27 commented Mar 17, 2018

@dotlambda you're right, this seems to be more suitable %)

@Ma27 Ma27 changed the title Fix tablib pythonPackages.tablib: fix build Mar 17, 2018
dotlambda
dotlambda requested changes Mar 17, 2018
View reviewed changes
pkgs/development/python-modules/tablib/default.nix Outdated
sha256 = "11wxchj0qz77dn79yiq30k4b4gsm429f4bizk4lm4rb63nk51kxq";
};

buildInputs = [ pytest unicodecsv pandas ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkInputs? (at least pytest)

pkgs/development/python-modules/tablib/default.nix Outdated
meta = with stdenv.lib; {
description = "Tablib: format-agnostic tabular dataset library";
homepage = http://python-tablib.org;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the correct license.

@Ma27
pythonPackages.tablib: fix build
4a0c040 
`openpyxl` v5 breaks `tablib`, the following patch fixes the API
incompatibility: https://github.com/kennethreitz/tablib/pull/296

See https://hydra.nixos.org/build/70694938/log
See ticket NixOS#36453
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.tablib python3.pkgs.tablib

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.tablib, python3.pkgs.tablib

Partial log (click to expand)

.....                                                                    [ 67%]
../../nix/store/x1ck7girhc5xwzd7wgr2kzj26gq5r9p2-python2.7-pandas-0.22.0/lib/python2.7/site-packages/pandas/tests/io/formats/test_eng_formatting.py . [ 67%]
.....                                                                    [ 67%]
../../nix/store/x1ck7girhc5xwzd7wgr2kzj26gq5r9p2-python2.7-pandas-0.22.0/lib/python2.7/site-packages/pandas/tests/io/formats/test_format.py . [ 67%]
........................................................................ [ 66%]
building of '/nix/store/rc8nf3sl2vr780kdalllkgfkcsgbn8a9-python2.7-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/p5hmrz270b1dv18zpwxdsajcb9f3ggqc-python2.7-tablib-0.12.1.drv': 1 dependencies couldn't be built
building of '/nix/store/223j1d7rmawq7jlv48v489lnrky6cisa-python3.6-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/vlb9imhhk0rvi87y6vbnd5hr5w8zysaj-python3.6-tablib-0.12.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/p5hmrz270b1dv18zpwxdsajcb9f3ggqc-python2.7-tablib-0.12.1.drv', '/nix/store/vlb9imhhk0rvi87y6vbnd5hr5w8zysaj-python3.6-tablib-0.12.1.drv' failed

@dotlambda dotlambda merged commit 6d3232f into NixOS:master Mar 17, 2018
@dotlambda
Copy link
Member

Cherry-picked in 039365d

@Ma27 Ma27 deleted the fix-tablib branch March 17, 2018 19:49
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.tablib, python3.pkgs.tablib

Partial log (click to expand)

copying path '/nix/store/a6s07mmbq5m2hnbk8mdj424ws6c5g2d9-python3.6-lxml-4.1.1' from 'https://cache.nixos.org'...
copying path '/nix/store/yi0qifn42qvk03mcsgslxw2b5k9siwgh-python2.7-openpyxl-2.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/8xq1m9glc79ycffh0mfgfc9dyk6z3419-python3.6-odfpy-1.3.6' from 'https://cache.nixos.org'...
copying path '/nix/store/cai896am72mpamqnd7mk060vbxwwn9vq-python3.6-xlrd-0.9.4' from 'https://cache.nixos.org'...
copying path '/nix/store/wzv1kkmk5r5vg3ldfdr04ba52l5pfgxy-python3.6-xlwt-1.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/7vzc731hh64hq5pq2g92w5bc5y5rkhrg-python2.7-tablib-0.12.1' from 'https://cache.nixos.org'...
copying path '/nix/store/fn5nrpwsabwc04q4099whf18fvsz9ksv-python3.6-openpyxl-2.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/bnx916lm0ckj4d2h390kiig2zknlqbgh-python3.6-tablib-0.12.1' from 'https://cache.nixos.org'...
/nix/store/7vzc731hh64hq5pq2g92w5bc5y5rkhrg-python2.7-tablib-0.12.1
/nix/store/bnx916lm0ckj4d2h390kiig2zknlqbgh-python3.6-tablib-0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @dotlambda @GrahamcOfBorg