Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sudo: fix description of sudo.wheelNeedsPassword #37198

Merged
merged 1 commit into from Mar 18, 2018
Merged

nixos/sudo: fix description of sudo.wheelNeedsPassword #37198

merged 1 commit into from Mar 18, 2018

Conversation

giraffito
Copy link
Contributor

Motivation for this change

The original description was reversed compared to the interpretation of the option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@giraffito
nixos/security: fix description of sudo.wheelNeedsPassword
b9639d7 
the previous description mistakenly described the opposite semantics
@srhb srhb changed the title nixos/security: fix description of sudo.wheelNeedsPassword nixos/sudo: fix description of sudo.wheelNeedsPassword Mar 16, 2018
@Mic92 Mic92 merged commit 705fee5 into NixOS:master Mar 18, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 18, 2018

Thanks!

@Mic92
Copy link
Member

Mic92 commented Mar 18, 2018

also backported to 18.03 and 17.09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giraffito @Mic92 @GrahamcOfBorg @Janik-Haag