nix-shell: allow symlinks to .drvs #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes persistent shell environments easier to use.
shlevy
reviewed
Mar 17, 2018
| @@ -271,10 +271,14 @@ void mainWrapped(int argc, char * * argv) | |||
| exprs = {state.parseStdin()}; | |||
| else | |||
| for (auto i : left) { | |||
| auto absolute = i; | |||
| try { | |||
| absolute = canonPath(absPath(i), true); | |||
There was a problem hiding this comment.
Do we care that this will also resolve symlinks in the store?
There was a problem hiding this comment.
I don't think so, since this only affects the .drv case.
There was a problem hiding this comment.
And what happens if there are symlinks in the store path (i.e. /nix/ is a symlink)? Does it move from «purity not guaranteed» to «doesn't work»?
There was a problem hiding this comment.
/nix is not allowed to be a symlink anyway
shlevy
approved these changes
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes persistent shell environments easier to use.