arrow-cpp: init at 0.8.0 #37196
Closed
arrow-cpp: init at 0.8.0 #37196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build arrow-cpp |
|
Success on x86_64-linux (full log) Attempted: arrow-cpp Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: arrow-cpp Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: arrow-cpp Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
teh
reviewed
Mar 16, 2018
| version = "0.8.0"; | ||
|
|
||
| src = fetchurl { | ||
| url = "http://apache.mesi.com.ar/arrow/arrow-${version}/apache-arrow-${version}.tar.gz"; |
teh
reviewed
Mar 16, 2018
| # detected by gcc7 | ||
| NIX_CFLAGS_COMPILE = [ "-Wno-error=implicit-fallthrough" ]; | ||
| preConfigure = '' | ||
| substituteInPlace CMakeLists.txt --replace "-Werror" "" |
There was a problem hiding this comment.
Can you add a comment why we need to disable errors completely?
There was a problem hiding this comment.
We could add
-Wno-error=zero-as-null-pointer-constant and -Wno-error=shadow to use with modern clang, but what is the point? Compilers will get more sophisticated diagnostics, there will be more warnings and it's not like we actually going to fix any of the code. So we should just let developers compile with -Werror
|
Hey, thanks for pulling this out! |
|
Success on x86_64-darwin (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
Mic92
reviewed
Mar 18, 2018
| description = "A cross-language development platform for in-memory data"; | ||
| homepage = https://arrow.apache.org/; | ||
| license = stdenv.lib.licenses.asl20; | ||
| platforms = stdenv.lib.platforms.unix; |
There was a problem hiding this comment.
Are you going to maintain this expression?
|
Success on x86_64-linux (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
@GrahamcOfBorg build python2Packages.pyarrow python35Packages.pyarrow python36Packages.pyarrow |
|
Failure on x86_64-linux (full log) Attempted: python2Packages.pyarrow The following builds were skipped because they don't evaluate on x86_64-linux: python35Packages.pyarrow, python36Packages.pyarrow Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python2Packages.pyarrow The following builds were skipped because they don't evaluate on x86_64-darwin: python35Packages.pyarrow, python36Packages.pyarrow Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: arrow-cpp, gflags, rapidjson Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: arrow-cpp, gflags, parquet-cpp, rapidjson Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: arrow-cpp, gflags, parquet-cpp, rapidjson Partial log (click to expand)
|
|
I can't reproduce darwin failure for pyarrow, it builds just fine for me on mac. This seems to be good to merge. |
|
Failure on aarch64-linux (full log) Attempted: python2Packages.pyarrow Partial log (click to expand)
|
Disables -Werror
Alternatively one could use
NIX_CFLAGS_COMPILE = [
"-Wno-error=implicit-fallthrough"
"-Wno-error=zero-as-null-pointer-constant"
"-Wno-error=shadow"
];
veprbl
force-pushed
the
arrow_cpp
branch
2 times, most recently
from
cfb804b
to
6b855cc
Compare
Also fix RPATH issues in pyarrow
|
Success on x86_64-linux (full log) Attempted: arrow-cpp, parquet-cpp, rapidjson Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: arrow-cpp, parquet-cpp, rapidjson Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: arrow-cpp, parquet-cpp, rapidjson Partial log (click to expand)
|
|
@GrahamcOfBorg build python2Packages.pyarrow |
|
Failure on x86_64-linux (full log) Attempted: python2Packages.pyarrow Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python2Packages.pyarrow Partial log (click to expand)
|
|
@GrahamcOfBorg build python2Packages.pyarrow |
|
Failure on x86_64-darwin (full log) Attempted: python2Packages.pyarrow Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python2Packages.pyarrow Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: arrow-cpp, parquet-cpp, rapidjson Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: arrow-cpp, parquet-cpp, rapidjson Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: arrow-cpp, parquet-cpp, rapidjson Partial log (click to expand)
|
|
moved to #38440 |
|
Failure on aarch64-linux (full log) Attempted: python2Packages.pyarrow Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: python2Packages.pyarrow Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)