Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workrave: 1.10.7 -> 1.10.20 #37209

Merged
merged 2 commits into from Mar 18, 2018
Merged

workrave: 1.10.7 -> 1.10.20 #37209

merged 2 commits into from Mar 18, 2018

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Mar 17, 2018

Also: switch to GTK-3, fix GSettings by using wrapGAppsHook.

Motivation for this change

Couldn't set the timers at all, making it pretty much useless. Switching it to gtk-3 is just to simplify by making it closer to upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@enolan
workrave: 1.10.7 -> 1.10.20
250c19c 
Also: switch to GTK-3, fix GSettings by using wrapGAppsHook.
@enolan
Copy link
Contributor Author

enolan commented Mar 17, 2018

Hold off reviewing this, sound is broken and I'm trying to figure it out.

@enolan
Copy link
Contributor Author

enolan commented Mar 17, 2018

OK, sound is working now, good to go.

@Mic92 Mic92 merged commit fc0a5f4 into NixOS:master Mar 18, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 18, 2018

also backported to 18.03

@enolan enolan deleted the upgrade-workrave branch February 22, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enolan @Mic92 @GrahamcOfBorg