Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TeX Gyre package sets #38404

Merged
merged 2 commits into from Apr 4, 2018

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Apr 3, 2018

Motivation

tex-gyre: use callPackages

Using callPackages instead of callPackage adds an override attribute to
each individual package instead of the set. Each member of the set is then just
a package so that lib.attrValues tex-gyre gives a list of packages that can be
installed.

tex-gyre-*-math: Move to tex-gyre-math package set

The tex-gyre-*-math fonts are moved to the tex-gyre-math set for consistency
with tex-gyre and to allow them to be easily installed together. Aliases are
created for backwards-compatibility.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC: @siddharthist

Using `callPackages` instead of `callPackage` adds an `override` attribute to
each individual package instead of the set. Each member of the set is then just
a package so that `lib.attrValues tex-gyre` gives a list of packages that can be
installed.
The `tex-gyre-*-math` fonts are moved to the `tex-gyre-math` set for consistency
with `tex-gyre` and to allow them to be easily installed together. Aliases are
created for backwards-compatibility.
@ttuegel ttuegel requested a review from jtojnar April 3, 2018 19:42
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttuegel ttuegel merged commit 130ee29 into NixOS:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants