Refactor TeX Gyre package sets #38404
Merged
+43
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `callPackages` instead of `callPackage` adds an `override` attribute to each individual package instead of the set. Each member of the set is then just a package so that `lib.attrValues tex-gyre` gives a list of packages that can be installed.
The `tex-gyre-*-math` fonts are moved to the `tex-gyre-math` set for consistency with `tex-gyre` and to allow them to be easily installed together. Aliases are created for backwards-compatibility.
GrahamcOfBorg
added
8.has: clean-up
10.rebuild-darwin: 0
langston-barrett
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tex-gyre: use
callPackagesUsing
callPackagesinstead ofcallPackageadds anoverrideattribute toeach individual package instead of the set. Each member of the set is then just
a package so that
lib.attrValues tex-gyregives a list of packages that can beinstalled.
tex-gyre-*-math: Move to
tex-gyre-mathpackage setThe
tex-gyre-*-mathfonts are moved to thetex-gyre-mathset for consistencywith
tex-gyreand to allow them to be easily installed together. Aliases arecreated for backwards-compatibility.
Testing
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)CC: @siddharthist