Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenJDK 10 and Eclipse to GTK 3 #38397

Merged
merged 2 commits into from Apr 5, 2018
Merged

Update OpenJDK 10 and Eclipse to GTK 3 #38397

merged 2 commits into from Apr 5, 2018

Conversation

jerith666
Copy link
Contributor

Motivation for this change

Eclipse's built-in browser wants webkitgtk, but the current version of webkitgtk in nixpkgs is built on gtk3. So, we need a version of the JDK that's built on gtk3 as well.

I've run with this for a couple of days at work and not noticed any problems with Eclipse. I also confirmed that jconsole, a swing app bundled with the JDK, works.

This is the same change as discussed in #36703, just for Java 10 instead of Java 9.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jerith666
openjdk10: gtk2 -> gtk3
2bd7c3a 
http://openjdk.java.net/jeps/283 "Enable GTK 3 on Linux" was included
in OpenJDK 9.

nothing else currently in nixpkgs is using 10, so this just lets us
establish a good baseline as things are ported onto it.  if needed,
the build could be parameterized so that any packages that turn out to
need gtk2 could still use it.
@jerith666
eclipse: jdk8 -> jdk10
cb66a74 
in combination with the parent commit that makes jdk10 use gtk3, this
lets us get onto a current webkitgtk.

since the current version of webkitgtk is still receiving security
updates, this also reverts 49ea0e2
"eclipse: Do not use webkitgtk2 by default".
@jerith666 jerith666 requested a review from rycee as a code owner April 3, 2018 16:37
@jerith666 jerith666 mentioned this pull request Apr 3, 2018
Closed
8 tasks
rycee
rycee approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@NeQuissimus NeQuissimus merged commit 59ddb3e into NixOS:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@rycee rycee rycee approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jerith666 @NeQuissimus @rycee @GrahamcOfBorg