Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.notebook: 5.4.0 -> 5.4.1 #37607

Merged
merged 1 commit into from Mar 22, 2018
Merged

pythonPackages.notebook: 5.4.0 -> 5.4.1 #37607

merged 1 commit into from Mar 22, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Mar 22, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

There is some stuff that should be changed in the expression, like changing buildInputs to checkInputs, removing the cat line, .... But that's independent from the update.

@vaibhavsagar
Copy link
Member Author

I'm happy to make a separate PR with those changes.

@dotlambda dotlambda merged commit ce2bf3b into NixOS:master Mar 22, 2018
@vaibhavsagar vaibhavsagar deleted the bump-pythonpackages-notebook branch March 22, 2018 09:41
@vaibhavsagar vaibhavsagar mentioned this pull request Mar 22, 2018
Merged
8 tasks
vaibhavsagar added a commit to vaibhavsagar/nixpkgs that referenced this pull request Mar 22, 2018
@vaibhavsagar
pythonPackages.notebook: cleanup
01f29bb 
As discussed in NixOS#37607 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @dotlambda @GrahamcOfBorg