Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b7dd2ef91dba
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 80ce3389405a
Choose a head ref
  • 6 commits
  • 10 files changed
  • 1 contributor

Commits on Mar 22, 2018

  1. deja-dup: clean up

    jtojnar committed Mar 22, 2018
    Copy the full SHA
    dd556b0 View commit details
  2. dbus-broker: clean up

    jtojnar committed Mar 22, 2018
    Copy the full SHA
    d04ab62 View commit details
  3. pipewire: clean up

    jtojnar committed Mar 22, 2018
    Copy the full SHA
    0bf6fb7 View commit details
  4. colord: 1.4.1 → 1.4.2

    jtojnar committed Mar 22, 2018
    11
    Copy the full SHA
    2abac54 View commit details
  5. gnome3.libgee: clean up

    jtojnar committed Mar 22, 2018
    Copy the full SHA
    3194951 View commit details
  6. spice-gtk: clean up

    jtojnar committed Mar 22, 2018
    Copy the full SHA
    80ce338 View commit details
22 changes: 9 additions & 13 deletions pkgs/applications/backup/deja-dup/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ stdenv, fetchurl, meson, ninja, pkgconfig, vala_0_38, gettext
, gnome3, libnotify, intltool, itstool, glib, gtk3, libxml2
{ stdenv, fetchurl, substituteAll, meson, ninja, pkgconfig, vala_0_40, gettext
, gnome3, libnotify, itstool, glib, gtk3, libxml2
, coreutils, libsecret, pcre, libxkbcommon, wrapGAppsHook
, libpthreadstubs, libXdmcp, epoxy, at-spi2-core, dbus, libgpgerror
, appstream-glib, desktop-file-utils, duplicity
@@ -15,20 +15,14 @@ stdenv.mkDerivation rec {
};

patches = [
./fix-paths.patch
(substituteAll {
src = ./fix-paths.patch;
inherit coreutils;
})
];

postPatch = ''
substituteInPlace libdeja/tools/duplicity/DuplicityInstance.vala --replace \
"/bin/rm" \
"${coreutils}/bin/rm"
'';

# couldn't find gio/gdesktopappinfo.h
NIX_CFLAGS_COMPILE = "-I${glib.dev}/include/gio-unix-2.0";

nativeBuildInputs = [
meson ninja pkgconfig vala_0_38 gettext intltool itstool
meson ninja pkgconfig vala_0_40 gettext itstool
appstream-glib desktop-file-utils libxml2 wrapGAppsHook
];

@@ -40,6 +34,8 @@ stdenv.mkDerivation rec {

propagatedUserEnvPkgs = [ duplicity ];

PKG_CONFIG_LIBNAUTILUS_EXTENSION_EXTENSIONDIR = "${placeholder "out"}/lib/nautilus/extensions-3.0";

postInstall = ''
glib-compile-schemas $out/share/glib-2.0/schemas
'';
21 changes: 10 additions & 11 deletions pkgs/applications/backup/deja-dup/fix-paths.patch
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
diff --git a/deja-dup/nautilus/meson.build b/deja-dup/nautilus/meson.build
index 04b136f3..ed8f7cba 100644
--- a/deja-dup/nautilus/meson.build
+++ b/deja-dup/nautilus/meson.build
@@ -31,6 +31,6 @@ shared_module('deja-dup', ['NautilusExtension.c'],
link_with: [dirhandling],
dependencies: [nautilus_dep],
install: true,
- install_dir: nautilus_dep.get_pkgconfig_variable('extensiondir'))
+ install_dir: join_paths(get_option('libdir'), 'nautilus', 'extensions-3.0'))
--- a/libdeja/tools/duplicity/DuplicityInstance.vala
+++ b/libdeja/tools/duplicity/DuplicityInstance.vala
@@ -159,7 +159,7 @@
// We already are pretty sure we don't have other duplicities in our
// archive directories, because we use our own and we ensure we only have
// one deja-dup running at a time via DBus.
- Posix.system("/bin/rm -f " + Shell.quote(cache_dir) + "/*/lockfile.lock");
+ Posix.system("@coreutils@/bin/rm -f " + Shell.quote(cache_dir) + "/*/lockfile.lock");

endif
Process.spawn_async_with_pipes(null, real_argv, real_envp,
SpawnFlags.SEARCH_PATH |
7 changes: 5 additions & 2 deletions pkgs/desktops/gnome-3/core/libgee/default.nix
Original file line number Diff line number Diff line change
@@ -6,18 +6,21 @@ in
stdenv.mkDerivation rec {
name = "${pname}-${version}";

outputs = [ "out" "dev" ];

src = fetchurl {
url = "mirror://gnome/sources/${pname}/${gnome3.versionBranch version}/${name}.tar.xz";
sha256 = "0c26x8gi3ivmhlbqcmiag4jwrkvcy28ld24j55nqr3jikb904a5v";
};

doCheck = true;

patches = [ ./fix_introspection_paths.patch ];

nativeBuildInputs = [ pkgconfig autoconf vala gobjectIntrospection ];
buildInputs = [ glib ];

PKG_CONFIG_GOBJECT_INTROSPECTION_1_0_GIRDIR = "${placeholder "dev"}/share/gir-1.0";
PKG_CONFIG_GOBJECT_INTROSPECTION_1_0_TYPELIBDIR = "${placeholder "out"}/lib/girepository-1.0";

passthru = {
updateScript = gnome3.updateScript {
packageName = pname;
13 changes: 0 additions & 13 deletions pkgs/desktops/gnome-3/core/libgee/fix_introspection_paths.patch

This file was deleted.

6 changes: 2 additions & 4 deletions pkgs/development/libraries/pipewire/default.nix
Original file line number Diff line number Diff line change
@@ -29,15 +29,13 @@ in stdenv.mkDerivation rec {
alsaLib ffmpeg libjack2 libudev libva xorg.libX11 sbc SDL2
];

patches = [
./fix-paths.patch
];

mesonFlags = [
"-Denable_docs=true"
"-Denable_gstreamer=true"
];

PKG_CONFIG_SYSTEMD_SYSTEMDUSERUNITDIR = "${placeholder "out"}/lib/systemd/user";

FONTCONFIG_FILE = fontsConf; # Fontconfig error: Cannot load default config file

doCheck = true;
8 changes: 0 additions & 8 deletions pkgs/development/libraries/pipewire/fix-paths.patch

This file was deleted.

13 changes: 4 additions & 9 deletions pkgs/development/libraries/spice-gtk/default.nix
Original file line number Diff line number Diff line change
@@ -19,23 +19,18 @@ in stdenv.mkDerivation rec {
};

buildInputs = [
spice-protocol celt_0_5_1 openssl libpulseaudio pixman gobjectIntrospection
spice-protocol celt_0_5_1 openssl libpulseaudio pixman
libjpeg_turbo zlib cyrus_sasl python pygtk usbredir gtk3 epoxy
polkit acl usbutils
];

nativeBuildInputs = [ pkgconfig gettext libsoup autoreconfHook vala ];
nativeBuildInputs = [ pkgconfig gettext libsoup autoreconfHook vala gobjectIntrospection ];

NIX_CFLAGS_COMPILE = "-fno-stack-protector";

# put polkit action in the $out/share/polkit-1/actions
preAutoreconf = ''
substituteInPlace configure.ac \
--replace 'POLICYDIR=`''${PKG_CONFIG} polkit-gobject-1 --variable=policydir`' "POLICYDIR=$out/share/polkit-1/actions"
'';
PKG_CONFIG_POLKIT_GOBJECT_1_POLICYDIR = "${placeholder "out"}/share/polkit-1/actions";

configureFlags = [
"--with-gtk3"
"--enable-introspection"
"--enable-vala"
];

11 changes: 2 additions & 9 deletions pkgs/os-specific/linux/dbus-broker/default.nix
Original file line number Diff line number Diff line change
@@ -17,13 +17,8 @@ stdenv.mkDerivation rec {

buildInputs = [ dbus glib linuxHeaders systemd ];

enableParallelBuilding = true;

prePatch = ''
substituteInPlace meson.build \
--replace "dep_systemd.get_pkgconfig_variable('systemdsystemunitdir')" "'$out/lib/systemd/system'" \
--replace "dep_systemd.get_pkgconfig_variable('systemduserunitdir')" "'$out/lib/systemd/user'"
'';
PKG_CONFIG_SYSTEMD_SYSTEMDSYSTEMUNITDIR = "${placeholder "out"}/lib/systemd/system";
PKG_CONFIG_SYSTEMD_SYSTEMDUSERUNITDIR = "${placeholder "out"}/lib/systemd/user";

postInstall = ''
install -Dm644 ../README $out/share/doc/dbus-broker/README
@@ -32,8 +27,6 @@ stdenv.mkDerivation rec {
-e 's,^ExecReload.*busctl,ExecReload=${systemd}/bin/busctl,'
'';

checkPhase = "ninja test";

doCheck = true;

meta = with stdenv.lib; {
23 changes: 11 additions & 12 deletions pkgs/tools/misc/colord/default.nix
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
{ stdenv, fetchurl, bash-completion
, glib, polkit, pkgconfig, gettext, gusb, lcms2, sqlite, systemd, dbus
, gobjectIntrospection, argyllcms, meson, ninja, libxml2, vala_0_38
, gobjectIntrospection, argyllcms, meson, ninja, libxml2, vala_0_40
, libgudev, sane-backends, udev, gnome3, makeWrapper }:

stdenv.mkDerivation rec {
name = "colord-1.4.1";
name = "colord-1.4.2";

src = fetchurl {
url = "http://www.freedesktop.org/software/colord/releases/${name}.tar.xz";
sha256 = "0m854clp8szvq38z16jpazzlqfb3lb3icxcfnsisfrc25748y1ib";
sha256 = "19zc9gldz469jshl16av7na459kwr5nhvs2pz98xm5lw582xaw2c";
};

enableParallelBuilding = true;

mesonFlags = [
"-Denable-sane=true"
"-Denable-vala=true"
@@ -23,19 +21,20 @@ stdenv.mkDerivation rec {
"-Denable-docs=false"
];

patches = [
./fix-build-paths.patch
];

nativeBuildInputs = [ meson pkgconfig vala_0_38 ninja gettext libxml2 gobjectIntrospection makeWrapper ];
nativeBuildInputs = [ meson pkgconfig vala_0_40 ninja gettext libxml2 gobjectIntrospection makeWrapper ];

buildInputs = [ glib polkit gusb lcms2 sqlite systemd dbus
bash-completion argyllcms libgudev sane-backends ];
buildInputs = [ glib polkit gusb lcms2 sqlite systemd dbus bash-completion argyllcms libgudev sane-backends ];

postInstall = ''
glib-compile-schemas $out/share/glib-2.0/schemas
'';

PKG_CONFIG_SYSTEMD_SYSTEMDSYSTEMUNITDIR = "${placeholder "out"}/lib/systemd/system";
PKG_CONFIG_SYSTEMD_SYSTEMDUSERUNITDIR = "${placeholder "out"}/lib/systemd/user";
PKG_CONFIG_SYSTEMD_TMPFILESDIR = "${placeholder "out"}/lib/tmpfiles.d";
PKG_CONFIG_BASH_COMPLETION_COMPLETIONSDIR= "${placeholder "out"}/share/bash-completion/completions";
PKG_CONFIG_UDEV_UDEVDIR = "${placeholder "out"}/lib/udev";

postFixup = ''
wrapProgram "$out/libexec/colord-session" \
--prefix XDG_DATA_DIRS : "$GSETTINGS_SCHEMAS_PATH:$out/share" \
74 changes: 0 additions & 74 deletions pkgs/tools/misc/colord/fix-build-paths.patch

This file was deleted.