Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squeezelite: 2016-05-27 -> 2018-08-14 #38033

Merged
merged 2 commits into from
Feb 23, 2019
Merged

squeezelite: 2016-05-27 -> 2018-08-14 #38033

merged 2 commits into from
Feb 23, 2019
+19 −31

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Regular update + get rid of the dedicated user by using DynamicUser = true

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 29, 2018
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@peterhoeg
squeezelite: 2016-05-27 -> 2018-08-14

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
4a73fa3
@peterhoeg
nixos squeezelite: run using DynamicUser
440556a
@peterhoeg peterhoeg changed the title squeezelite: 2016-05-27 -> 2017-12-20 WIP squeezelite: 2016-05-27 -> 2018-08-14 Oct 10, 2018
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 20, 2018

@peterhoeg was that ready to merge for you? looks polished enough for me

@peterhoeg
Copy link
Member Author

It's probably fine but I haven't set up dedicated device on which to test it out.

@ryantm
Copy link
Member

ryantm commented Feb 23, 2019

@GrahamcOfBorg build squeezelite

@ryantm ryantm merged commit 7776de0 into NixOS:master Feb 23, 2019
@peterhoeg peterhoeg deleted the f/slite branch March 18, 2019 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @GrahamcOfBorg @c0bw3b @ryantm