Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: enable bash command completion by default #38038

Closed

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Because command completion improves out-of-the-box user experience a lot
(IMHO).

Remove "programs.bash.enableCompletion = true" from
nixos-generate-config.pl, which feels superflous now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Because it improves out-of-the-box user experience a lot (IMHO).
(zsh completion is already on by default.)

Remove "programs.bash.enableCompletion = true" from
nixos-generate-config.pl, which feels superflous now.
@bjornfor bjornfor force-pushed the enable-bash-command-completion branch from bc04e9a to e9a66e4 Compare March 29, 2018 11:56
@bjornfor
Copy link
Contributor Author

I updated the commit message to include that zsh already enables completion by default.

@hedning
Copy link
Contributor

hedning commented Mar 29, 2018

@volth #32534 should've fixed the issue.

@bjornfor
Copy link
Contributor Author

Applied to master (80b6513).

@bjornfor bjornfor closed this Apr 13, 2018
@bjornfor bjornfor deleted the enable-bash-command-completion branch April 13, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants