linuxPackages_custom: fix missing argument and add test #38034
Conversation
The required argument 'hostPlatform' was missing from linuxPackages_custom's call to linuxManualConfig. In order to prevent this in the future, this commit adds linuxPackages_custom_tinyconfig_kernel so linuxPackages_custom gets tested. This also adds linuxConfig, to derivate default linux configurations via make defconfig, make tinyconfig, etc.
|
@GrahamcOfBorg build linuxPackages_custom_tinyconfig_kernel |
|
@thoughtpolice ready for merge? |
| @@ -35,6 +35,8 @@ in { | |||
| extraMeta ? {}, | |||
| # Whether to utilize the controversial import-from-derivation feature to parse the config | |||
| allowImportFromDerivation ? false, | |||
| # ignored | |||
| features ? null, | |||
There was a problem hiding this comment.
Excuse me if I'm missing something obvious -- is this change necessary? Am I missing something?
There was a problem hiding this comment.
features has become a mandatory argument for kernels. I don't remember where it is passed as an argument, but without it evaluation fails because some other code expects to be able to pass a features argument. I'm not sure where that is, as I said, but this override supports the idea.
This ignores the features parameter entirely, which kind of seems appropriate for a custom kernel. Of course someone could write the code to validate the custom configuration against it and expose it via passthru but that's not going to be part of this bugfix.
There was a problem hiding this comment.
Ah, thanks for the follow up! (I reviewed it a bit 'out of context' since I was busy earlier and hadn't looked deeper). This otherwise looks good to me; I'll merge this (and the backport) soon...
The required argument 'hostPlatform' was missing from linuxPackages_custom's call to linuxManualConfig. In order to prevent this in the future, this commit adds linuxPackages_custom_tinyconfig_kernel so linuxPackages_custom gets tested. This also adds linuxConfig, to derivate default linux configurations via make defconfig, make tinyconfig, etc. Closes #38034. Signed-off-by: Austin Seipp <aseipp@pobox.com>
See also backport to 18.03, #38035
The required argument 'hostPlatform' was missing from linuxPackages_custom's
call to linuxManualConfig.
In order to prevent this in the future, this commit adds
linuxPackages_custom_tinyconfig_kernel so linuxPackages_custom gets tested.
This also adds linuxConfig, to derivate default linux configurations
via make defconfig, make tinyconfig, etc.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)