Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: fixed rocksdb_lite build #36920

Closed
wants to merge 1 commit into from
Closed

rocksdb: fixed rocksdb_lite build #36920

wants to merge 1 commit into from

Conversation

corpix
Copy link
Contributor

@corpix corpix commented Mar 13, 2018

Motivation for this change

I saw rocksdb_lite is failing in the latest builds, so I decided to fix it :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

matthewbauer
matthewbauer requested changes Apr 23, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict

@corpix
Copy link
Contributor Author

corpix commented Apr 23, 2018

Rebase resulted into empty changeset :) Fix already in master

@corpix corpix closed this Apr 23, 2018
@corpix corpix deleted the fix/rocksdb branch April 23, 2018 17:43
@infinisil
Copy link
Member

Whoops that was me in #38415, should've checked PRs first, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corpix @infinisil @matthewbauer @GrahamcOfBorg