Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 7.58.0 -> 7.59.0 #36963

Closed
wants to merge 1 commit into from
Closed

curl: 7.58.0 -> 7.59.0 #36963

wants to merge 1 commit into from

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 14, 2018

Motivation for this change

Changelog: https://curl.haxx.se/changes.html#7_59_0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor Author

etu commented Mar 14, 2018

cc @lovek323 :)

@adisbladis
Copy link
Member

@etu Please rebase this on staging.

@etu
Copy link
Contributor Author

etu commented Mar 14, 2018

There seems to have been some security related fixes in this release as well:
https://curl.haxx.se/docs/security.html

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-1000120
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-1000121
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-1000122

@etu etu changed the base branch from master to staging March 14, 2018 09:42
@etu
Copy link
Contributor Author

etu commented Mar 14, 2018

@adisbladis Rebased on staging, changed PR to be to staging and updated commit message to contain the CVE links.

@ttuegel ttuegel removed their request for review March 14, 2018 12:28
@FRidh FRidh removed their request for review March 15, 2018 15:12
@vcunat
Copy link
Member

vcunat commented Mar 18, 2018

We have this update on staging already: 837ecc2.

@vcunat vcunat closed this Mar 18, 2018
@etu etu deleted the curl-upgrade branch March 18, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@orivej orivej Awaiting requested review from orivej

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @adisbladis @vcunat @GrahamcOfBorg