-
-
Notifications
You must be signed in to change notification settings - Fork 345
KSP 1.4 and DLC detection #2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As far as detecting the DLC, it should (hopefully) be as simple as detecting the presence or lack thereof of specific files in the installation directory. This should piggyback off the existing autodetect mechanism and create a virtual package named |
We should also consider DLC versioning. Will updates to the DLC always be tied to a new KSP release (and therefore could share versioning) or would it have to be versioned separately... |
I'm not sure whether we should handle missions made with the Making History DLC. Do they fall into our remit? We definitely need to detect and flag the DLC for conflicts and depends, though. |
If modders start making custom missions I guess the users will expect us to start indexing said missions. |
Making History's release date has been announced: March 13th, 2018. CKAN has just over a month to get ready. |
Ok, so do we handle Making History purely as an Autodetected mod, tagged as DLC (Pro: Minimal code changes required), or do we write some special DLC detection code to inject the prereq? |
How would that differ from reusing the autodetect mechanism? I took a look at this briefly to see what would have to be done. It seems relatively straightforward with one annoyance: the test for if something is an autodetected mod is if its version is of type In summary these are the minimum changes I believe are necessary for support:
Bonus
I should have some time to do this if this is what we want to do and nobody else has a burning desire to. |
Huge +1 on changing our "Autodetected" DllVersion to an "Unmanaged" marker that can track version numbers. Perhaps we could have a right-click menu option that will let users select the correct version number for an unmanaged object if we can't figure it out. We could then add a tag to those Unmanaged objects for those that could in principle be brought back under CKAN management by a plugin. |
Now that Making History is out it seems that detecting the DLC is just a matter of testing for the presence of I'll update #2326 witht he appropriate code. |
@ayan4m1 @Dazpoet @dbent @linuxgurugamer @politas @Postremus @techman83
We should make some prep work for the upcoming release. Supporting KSP 1.4 will be fairly easy, just another version. But this time there will also be a dlc available. People will be able to make missions/mods for the dlc but we should only make this available for the users who have the dlc.
We'll have to wait for the release to see how the dlc can be detected by CKAN, but could we make any preparations for it?
- 1.3 Prep
The text was updated successfully, but these errors were encountered: