Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 1aaed1724406
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: ba816ee08721
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 13, 2018

  1. nixos/tests/virtualbox: Work around test failures

    I've started digging into the actual cause of the problem a week ago but
    didn't continue fixing this.
    
    The reason why the tests are failing is because
    torvalds/linux/commit/72f5e08dbba2d01aa90b592cf76c378ea233b00b has
    remapped the location of the TSS into the CPU entry area and we did
    update our default kernel to version 4.14 in 88530e02b6fa.
    
    Back to VirtualBox: The guru meditation happens in
    selmRCGuestTssPostWriteCheck, which I think is only a followup error. I
    believe the right location couldn't be determined by VirtualBox and thus
    the write check function triggers that panic because it's reading from
    the wrong location.
    
    So the actual problem *only* surfaces whenever we use software
    virtualization, which we do for our tests because we don't have nested
    virtualization available.
    
    Our tests are also for testing the functionality of VirtualBox itself
    and not certain kernel versions or kernel features, so for the time
    being and until this is fixed, let's actually use kernel version 4.9 for
    the guests within the VM tests. Kernel 4.9 didn't have the mentioned
    change of the TSS location and thus the tests succeed.
    
    Signed-off-by: aszlig <aszlig@nix.build>
    Cc: @dtzWill
    aszlig committed Mar 13, 2018
    Copy the full SHA
    ba816ee View commit details
    Browse the repository at this point in the history