Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doit clean #2980

Merged
merged 3 commits into from Mar 13, 2018
Merged

Fix doit clean #2980

merged 3 commits into from Mar 13, 2018

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Mar 13, 2018

Doit 0.31 changes the DoitClean API, this makes it work.

Kwpolska
Kwpolska approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda ugly, but it works. Perhaps add a comment to explain it? (We could also drop support for doit <=0.31.0, although that doesn’t really matter.)

@ralsina ralsina merged commit a976064 into master Mar 13, 2018
@Kwpolska Kwpolska deleted the fix-doit-clean branch March 31, 2018 08:34
Kwpolska pushed a commit that referenced this pull request Mar 31, 2018
@ralsina @Kwpolska
Fix doit clean (#2980)
46f343d 
* Use doit clean as required by doit 0.31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska