Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdynd: fix build w/gcc7 #36935

Merged
merged 1 commit into from Mar 14, 2018
Merged

libdynd: fix build w/gcc7 #36935

merged 1 commit into from Mar 14, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 13, 2018

Motivation for this change

didn't build with gcc7.

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libdynd

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hfd0fd7p1xnb370wnzdsz53gh8zds19n-libdynd-0.7.2/lib  /nix/store/hfd0fd7p1xnb370wnzdsz53gh8zds19n-libdynd-0.7.2/bin
patching script interpreter paths in /nix/store/hfd0fd7p1xnb370wnzdsz53gh8zds19n-libdynd-0.7.2
/nix/store/hfd0fd7p1xnb370wnzdsz53gh8zds19n-libdynd-0.7.2/bin/libdynd-config: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/hfd0fd7p1xnb370wnzdsz53gh8zds19n-libdynd-0.7.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/3kd99ibi869zm2a096x25111l04hmcgq-libdynd-0.7.2-dev
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/3kd99ibi869zm2a096x25111l04hmcgq-libdynd-0.7.2-dev
checking for references to /build in /nix/store/3kd99ibi869zm2a096x25111l04hmcgq-libdynd-0.7.2-dev...
/nix/store/hfd0fd7p1xnb370wnzdsz53gh8zds19n-libdynd-0.7.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libdynd

Partial log (click to expand)

shrinking /nix/store/4v9qsd9sck98bdlcsh040j6by053q5ch-libdynd-0.7.2/lib/libdynd.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4v9qsd9sck98bdlcsh040j6by053q5ch-libdynd-0.7.2/lib  /nix/store/4v9qsd9sck98bdlcsh040j6by053q5ch-libdynd-0.7.2/bin
patching script interpreter paths in /nix/store/4v9qsd9sck98bdlcsh040j6by053q5ch-libdynd-0.7.2
/nix/store/4v9qsd9sck98bdlcsh040j6by053q5ch-libdynd-0.7.2/bin/libdynd-config: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/4v9qsd9sck98bdlcsh040j6by053q5ch-libdynd-0.7.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/p3j7b0n0nwbrnjjrrqr607ah36idzqqg-libdynd-0.7.2-dev
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/p3j7b0n0nwbrnjjrrqr607ah36idzqqg-libdynd-0.7.2-dev
checking for references to /build in /nix/store/p3j7b0n0nwbrnjjrrqr607ah36idzqqg-libdynd-0.7.2-dev...

@andir
Copy link
Member

andir commented Mar 14, 2018

Since upstream seems to be far from fixing such issues (libdynd/libdynd@760ec4e#diff-354f30a63fb0907d4ad57269548329e3R94) this is probably an okay-ish fix for this issue.

@andir andir merged commit 1406823 into NixOS:master Mar 14, 2018
@xeji xeji deleted the p/libdynd branch March 17, 2018 12:32
@xeji xeji mentioned this pull request Mar 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @andir