pythonPackages.diff_cover: fix build #36934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason for renaming when the package is called |
|
@dotlambda well, I actually assumed that we prefer attribute names with dashes as separation (I usually got the feedback the dashes are preferable). However if we want to match the attribute names with the PyPI package names, I can revert this change %) |
|
I think someday this might be changed for all Python packages, but until it is I'd keep it as is. |
In order to adjust the language with `LC_ALL` properly the `glibcLocales` is needed as `checkInput`. This was the only thing preventing the testsuite from passing. See ticket NixOS#36453 See https://hydra.nixos.org/build/70682982/nixlog/3
|
@dotlambda anything else?:) |
|
@GrahamcOfBorg build python2.pkgs.diff_cover python3.pkgs.diff_cover |
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.diff_cover, python3.pkgs.diff_cover Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.diff_cover, python3.pkgs.diff_cover Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In order to adjust the language with
LC_ALLproperly theglibcLocalesis needed ascheckInput. This was the only thingpreventing the testsuite from passing.
Furthermore I moved the default package from
diff_covertodiff-coverand added an alias fordiff_coverfor compatibilityreasons.
See ticket #36453
See https://hydra.nixos.org/build/70682982/nixlog/3
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)