Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python27Packages.nevow: fix build, 0.14.2->0.14.3 #36944

Merged
merged 1 commit into from Mar 14, 2018
Merged

python27Packages.nevow: fix build, 0.14.2->0.14.3 #36944

merged 1 commit into from Mar 14, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 13, 2018 •
edited

Motivation for this change

didn't build (error in test setup).

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji xeji requested a review from FRidh as a code owner March 13, 2018 23:27
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.nevow

Partial log (click to expand)

post-installation fixup
moving /nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2/doc to /nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2/lib  /nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2/bin
patching script interpreter paths in /nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2
checking for references to /build in /nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2...
wrapping `/nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2/bin/nit'...
wrapping `/nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2/bin/nevow-xmlgettext'...
/nix/store/zzc035sr9x04scmyz29sfmn9vmfwcy1m-python2.7-nevow-0.14.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.nevow

Partial log (click to expand)

post-installation fixup
moving /nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2/doc to /nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2/lib  /nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2/bin
patching script interpreter paths in /nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2
checking for references to /build in /nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2...
wrapping `/nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2/bin/nevow-xmlgettext'...
wrapping `/nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2/bin/nit'...
/nix/store/ijm42mycjmx7vpb7qa24a9wihl19441r-python2.7-nevow-0.14.2

@Ma27
Copy link
Member

Ma27 commented Mar 14, 2018

may I ask what broke the tests?

@xeji
Copy link
Contributor Author

xeji commented Mar 14, 2018

See this hydra log. The error occurs in setting up some javascript-related test case.

Strangely though, nevow wasn't changed since 17.09, and the same expression builds in 17.09 without running any tests. So the broken test case may have been there for much longer.

No idea what change triggered the tests to be run now. That's why I propose to disable them.

@dotlambda
Copy link
Member

It seems like

checkPhase = ''
  trial formless nevow
'';

makes the tests work.
I'd also ask you to move the expression to a dedicated directory in pkgs/development/python-modules.

@xeji
Copy link
Contributor Author

xeji commented Mar 14, 2018

Thank you, will do. Do we have a policy/criteria what should go in python-modules/ vs. python-packages.nix ?

@dotlambda
Copy link
Member

Nothing should go in python-packages.nix, just the callPackage stuff.

@xeji
Copy link
Contributor Author

xeji commented Mar 14, 2018

Makes sense, looks kinda mixed right now.

@xeji
Copy link
Contributor Author

xeji commented Mar 14, 2018

tests run fine now. moved to python-modules/ , plus a little cleanup and a minor version bump.

@xeji xeji changed the title python27Packages.nevow: fix build python27Packages.nevow: fix build, 0.14.2->0.14.3 Mar 14, 2018
dotlambda
dotlambda requested changes Mar 14, 2018
View reviewed changes
pkgs/development/python-modules/nevow/default.nix Outdated
{ stdenv, buildPythonPackage, fetchPypi, isPy3k, twisted }:

buildPythonPackage rec {
name = "nevow-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped that before but then the package name is capitalized (it's capitalized on pypi). If we do that, it will be called python2.7-Nevow. Do we want that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we do. It isn't relevant anyway. The advantage of not having name is that we can easily override the version.

dotlambda
dotlambda reviewed Mar 14, 2018
View reviewed changes
pkgs/development/python-modules/nevow/default.nix Outdated
trial formless nevow
'';

postInstall = "twistd --help > /dev/null";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line intended to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno. was there before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just drop it

@xeji
pythonPackages.nevow: fix build, 0.14.2->0.14.3
9a10c55 
fix tests, minor update, move to development/python-modules/
@xeji
Copy link
Contributor Author

xeji commented Mar 14, 2018

@dotlambda thank you for the review, done.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.nevow

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.nevow

Partial log (click to expand)

    assertion_func(first, second, msg=msg)
  File "/nix/store/7b2z0vfbs9539ga4pxx5gmli47rz5y3n-python-2.7.14/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 'g:h' != 'g:///h'

nevow.test.test_url.Serialization.test_rfc1808
-------------------------------------------------------------------------------
Ran 902 tests in 1.446s

PASSED (skips=29, expectedFailures=4, successes=869)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.nevow

Partial log (click to expand)

    assertion_func(first, second, msg=msg)
  File "/nix/store/5crgsfgy8n7v50hrihx4mhxdqa01nrmw-python-2.7.14/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 'g:h' != 'g:///h'

nevow.test.test_url.Serialization.test_rfc1808
-------------------------------------------------------------------------------
Ran 902 tests in 7.481s

PASSED (skips=29, expectedFailures=4, successes=869)

@dotlambda dotlambda merged commit c8a7aa1 into NixOS:master Mar 14, 2018
@dotlambda
Copy link
Member

Cherry-picked to release-18.03 in f2d24b8.

@dotlambda
Copy link
Member

@FRidh I accidentally cherry-picked to staging before. But I don't think this is a problem, is it?

@xeji xeji deleted the nevow branch March 14, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @GrahamcOfBorg @Ma27 @dotlambda