Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-auth: remove #36938

Merged
merged 1 commit into from Mar 24, 2018
Merged

aws-auth: remove #36938

merged 1 commit into from Mar 24, 2018

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Mar 13, 2018

No longer works with current awscli versions, unmaintained upstream.

Motivation for this change

Turns out aws-auth used a bit of a hack to work - it was reliant on a specific file name format for awscli's credential cache, which of course has no reason to stick to a particular format, so is broken from 1.14 onwards. See Crown-Commercial-Service/aws-auth#1 - as you can see there does exist a patch to make this work with 1.14, but of course it also relies on a specific format and is just as likely to break again. I think the best thing long term is probably to retire this package and I might point the release-18.03 version at the patched version for continuity? Currently it's broken, along with release-17.09's version too, thanks to its awscli version being quietly bumped up to the 1.14 branch without warning a few weeks ago...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

No longer works with current awscli versions, unmaintained upstream
@matthewbauer matthewbauer merged commit 814225c into NixOS:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants