ape: init at 6.7-131003 #36957
Closed
ape: init at 6.7-131003 #36957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback? Anything I can address/help with? |
|
Any concerns about these derivations? |
yrashk
force-pushed
the
attempto-ape
branch
3 times, most recently
from
13da45b
to
618f7b0
Compare
|
Whom should I ping to review this PR? |
cleverca22
reviewed
Apr 22, 2018
| callPackage ./. { | ||
| pname = "ape-clex"; | ||
| lexicon = "${attemptoClex}/clex_lexicon.pl"; | ||
| description = "Parser for Attempto Controlled English (ACE) with a large lexicon (~100,000 entries)"; |
There was a problem hiding this comment.
why are these values not in default.nix?
There was a problem hiding this comment.
They are -- there are just two variations of the package, with the small lexicon and a larger one. Smaller lexicon is covered by LGPL, however, the larger one is GPL.
|
Closed for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Attempto APE is not in Nixpkgs
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)