Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfitsio: Change hash for 3.43 to reflect upstream #36959

Merged
merged 1 commit into from Apr 17, 2018
Merged

cfitsio: Change hash for 3.43 to reflect upstream #36959

merged 1 commit into from Apr 17, 2018

Conversation

chrisburr
Copy link
Contributor

@chrisburr chrisburr commented Mar 14, 2018 •
edited

Motivation for this change

The file for cfitsio 3.43 was updated 2 days after #36316 (see below). I can't find a reason for this change, however it renders the current version unbuildable as the source is unavailable.

As FTP links seem to not work, here is the URL showing the modified time of the file:
ftp://heasarc.gsfc.nasa.gov/software/fitsio/c/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@chrisburr chrisburr changed the title cfitsio: Change has for 3.43 to reflect upstream cfitsio: Change hash for 3.43 to reflect upstream Mar 14, 2018
@ryantm
Copy link
Member

ryantm commented Mar 15, 2018

@GrahamcOfBorg build cfitsio

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cfitsio

Partial log (click to expand)

cp fitsio.h fitsio2.h longnam.h drvrsmem.h /nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43/include
cp cfitsio.pc /nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43/lib/pkgconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43
shrinking /nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43/lib/libcfitsio.so.5.3.43
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43/lib 
patching script interpreter paths in /nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43
checking for references to /tmp/nix-build-cfitsio-3.43.drv-0 in /nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43...
/nix/store/5qskgx9jbrbii7kjpq26pkasfci4fbiw-cfitsio-3.43

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cfitsio

Partial log (click to expand)

cp fitsio.h fitsio2.h longnam.h drvrsmem.h /nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43/include
cp cfitsio.pc /nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43/lib/pkgconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43
shrinking /nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43/lib/libcfitsio.so.5.3.43
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43/lib
patching script interpreter paths in /nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43
checking for references to /build in /nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43...
/nix/store/45xcf1cdz41nsbl4mfs3l0jmc2m92pd0-cfitsio-3.43

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: cfitsio

No log is available.

@matthewbauer matthewbauer merged commit c3026c4 into NixOS:master Apr 17, 2018
@chrisburr chrisburr deleted the patch-2 branch April 17, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisburr @ryantm @GrahamcOfBorg @matthewbauer