Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgksu: fix build #36940

Merged
merged 1 commit into from Mar 15, 2018
Merged

libgksu: fix build #36940

merged 1 commit into from Mar 15, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 13, 2018

Motivation for this change

no longer builds after gtk-doc bump in eb03685

https://hydra.nixos.org/build/70843465/nixlog/1

/cc @romildo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libgksu

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12
shrinking /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12/bin/.gksu-properties-wrapped
/nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12
shrinking /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12/lib/libgksu2.so.0.0.2
shrinking /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12/lib/libgksu/gksu-run-helper
gzipping man pages under /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12/lib  /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12/bin
patching script interpreter paths in /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12
checking for references to /build in /nix/store/a56drqak2l9z62s7dxkyjcg3b14pv7zb-libgksu-2.0.12...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libgksu

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12
shrinking /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12/bin/.gksu-properties-wrapped
shrinking /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12/lib/libgksu/gksu-run-helper
shrinking /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12/lib/libgksu2.so.0.0.2
gzipping man pages under /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12/lib  /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12/bin
patching script interpreter paths in /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12
checking for references to /build in /nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12...
/nix/store/20mzircgxm12582f8x4qkzi8r0gwvi6f-libgksu-2.0.12

@pbogdan
Copy link
Member Author

pbogdan commented Mar 13, 2018

@GrahamcOfBorg build gksu

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gksu

Partial log (click to expand)

Wrapping program /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2/bin/gksu
Wrapping program /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2/bin/gksudo
shrinking RPATHs of ELF executables and libraries in /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2
shrinking /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2/bin/.gksu-wrapped
gzipping man pages under /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2/bin
patching script interpreter paths in /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2
checking for references to /build in /nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2...
/nix/store/5q2qcm78kdz2z4ww7gz2s381af6z0baj-gksu-2.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gksu

Partial log (click to expand)

Wrapping program /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2/bin/gksudo
Wrapping program /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2/bin/gksu
shrinking RPATHs of ELF executables and libraries in /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2
shrinking /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2/bin/.gksu-wrapped
gzipping man pages under /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2/bin
patching script interpreter paths in /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2
checking for references to /build in /nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2...
/nix/store/4b8qq315zr3vbispsdrsj7jd7jyqrvr5-gksu-2.0.2

romildo
romildo approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtkdoc-mktmpl has been removed from recent gtk-doc.

@andir
Copy link
Member

andir commented Mar 14, 2018 •
edited

I am not a huge fan of removing documentation so just a thought:

Have you considered using gtkdoc-mktmpl from gnome2.gtk_doc instead? It is probably unsure how long that will continue to be maintained thought…

If that doesn't make sense I'd be in favor of merging this.

@pbogdan
Copy link
Member Author

pbogdan commented Mar 14, 2018

AFAICT it was already the case that the package didn't contain documentation, docs were built but then discarded in post fixup (you can see it in the last successful Hydra build - https://hydra.nixos.org/build/70666909/log). Further gtk-doc and gnome2.gtk-doc appear to be the same thing so I'm not sure what else to try..

@andir
Copy link
Member

andir commented Mar 15, 2018

Alright, thats good enough for me :-)

@andir andir merged commit 2469e7e into NixOS:master Mar 15, 2018
@pbogdan pbogdan deleted the libgksu-fix-build branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @GrahamcOfBorg @andir @romildo