Tests for zero-bit field compiler error

Andrea Orru · Andrea Orru · commit c828c23f7105 · 2018-03-13T22:07:40.000-07:00
diff --git a/src/ir.cpp b/src/ir.cpp
@@ -15223,10 +15223,10 @@ static TypeTableEntry *ir_analyze_instruction_offset_of(IrAnalyze *ira,
     }
 
     if (field->type_entry->zero_bits) {
-      ir_add_error(ira, field_name_value,
-                   buf_sprintf("zero-bit field '%s' in struct '%s' has no offset",
-                               buf_ptr(field_name), buf_ptr(&container_type->name)));
-      return ira->codegen->builtin_types.entry_invalid;
+        ir_add_error(ira, field_name_value,
+                     buf_sprintf("zero-bit field '%s' in struct '%s' has no offset",
+                                 buf_ptr(field_name), buf_ptr(&container_type->name)));
+        return ira->codegen->builtin_types.entry_invalid;
     }
     size_t byte_offset = LLVMOffsetOfElement(ira->codegen->target_data_ref, container_type->type_ref, field->gen_index);
     ConstExprValue *out_val = ir_build_const_from(ira, &instruction->base);
diff --git a/test/compile_errors.zig b/test/compile_errors.zig
@@ -3141,4 +3141,14 @@ pub fn addCases(cases: &tests.CompileErrorContext) void {
         \\}
     ,
         ".tmp_source.zig:4:9: error: type 'S' is not copyable; cannot pass by value");
+
+    cases.add("taking offset of void field in struct",
+        \\const Empty = struct {
+        \\    val: void,
+        \\};
+        \\export fn foo() void {
+        \\    const fieldOffset = @offsetOf(Empty, "val");
+        \\}
+    ,
+        ".tmp_source.zig:5:42: error: zero-bit field 'val' has no offset in struct 'Empty'");
 }

Original file line number	Diff line number	Diff line change
`@@ -15223,10 +15223,10 @@ static TypeTableEntry ir_analyze_instruction_offset_of(IrAnalyze ira,`
`15223`	`15223`	`}`
`15224`	`15224`
`15225`	`15225`	`if (field->type_entry->zero_bits) {`
`15226`		`- ir_add_error(ira, field_name_value,`
`15227`		`- buf_sprintf("zero-bit field '%s' in struct '%s' has no offset",`
`15228`		`- buf_ptr(field_name), buf_ptr(&container_type->name)));`
`15229`		`- return ira->codegen->builtin_types.entry_invalid;`
	`15226`	`+ ir_add_error(ira, field_name_value,`
	`15227`	`+ buf_sprintf("zero-bit field '%s' in struct '%s' has no offset",`
	`15228`	`+ buf_ptr(field_name), buf_ptr(&container_type->name)));`
	`15229`	`+ return ira->codegen->builtin_types.entry_invalid;`
`15230`	`15230`	`}`
`15231`	`15231`	`size_t byte_offset = LLVMOffsetOfElement(ira->codegen->target_data_ref, container_type->type_ref, field->gen_index);`
`15232`	`15232`	`ConstExprValue *out_val = ir_build_const_from(ira, &instruction->base);`