Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 7afdc8d4a100
Choose a base ref
...
head repository: NixOS/nix
compare: 56f2ed00813f
Choose a head ref
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 25, 2018

  1. tests: test nix search behavior

    @dtzWill
    dtzWill committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    8282c60 View commit details
    Browse the repository at this point in the history

  2. nix search: fix bug where we wrote to cache when shouldn't, breaking 

    This is exposed by the tests added previously,
and resolves the error reported in #1892:
"expected JSON value".
    @dtzWill
    dtzWill committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    3cac873 View commit details
    Browse the repository at this point in the history

  3. nix search: explicitly handle empty search string, fixes #1893 

    This is important since this is given as an example.
Other patterns containing "empty search string" will still
be handled differently on different platforms ("asdf|")
but that's less of an issue.
    @dtzWill
    dtzWill committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    009cf9c View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. tests/search.sh: simplify, don't rely on consistent ordering

    @dtzWill
    dtzWill committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c577186 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Merge pull request #1906 from dtzWill/fix/nix-search 

    nix search: tests and fix #1893 and part of #1892
    @shlevy
    shlevy committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    56f2ed0 View commit details
    Browse the repository at this point in the history