Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetbrains updates #36943

Merged
merged 10 commits into from Mar 22, 2018
Merged

Jetbrains updates #36943

merged 10 commits into from Mar 22, 2018

Conversation

averelld
Copy link
Contributor

Motivation for this change

Various updates via script. Only idea has been tested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@averelld averelld requested a review from edwtjo as a code owner March 13, 2018 23:05
@andir
Copy link
Member

andir commented Mar 14, 2018

Thank your for taking care of this 👍.

It is probably a bit picky but usually a commit should use the proper attribute names of an expression. In your case the commits are missing the prefix jetbrains..

Besides that they all are valid and install just fine.

andir
andir requested changes Mar 14, 2018
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the jetbrains. prefix to the commit messages.

@jokogr jokogr mentioned this pull request Mar 19, 2018
Closed
8 tasks
edwtjo
edwtjo approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@edwtjo edwtjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@edwtjo edwtjo merged commit 33e6ef1 into NixOS:master Mar 22, 2018
This was referenced Mar 22, 2018
Closed
Closed
@Mic92
Copy link
Member

Mic92 commented Mar 22, 2018 •
edited

Same problem as in my pull request:
webstorm does not start:

$ webstorm
Start Failed: Internal error. Please report to http://jb.gg/ide/critical-startup-errors
java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.intellij.ide.Bootstrap.main(Bootstrap.java:39)
        at com.intellij.idea.Main.main(Main.java:78)
Caused by: java.lang.UnsatisfiedLinkError: /nix/store/v39g3hkkkvzv620xgs3dwikjzm6mg0wg-webstorm-2017.3.5/webstorm-2017.3.5/jre64/lib/amd64/libawt_xawt.so: libXext.so.6: cannot open shared object file: No such file or directory
        at java.lang.ClassLoader$NativeLibrary.load(Native Method)
        at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1941)
        at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1824)
        at java.lang.Runtime.load0(Runtime.java:809)
        at java.lang.System.load(System.java:1086)
        at java.lang.ClassLoader$NativeLibrary.load(Native Method)
        at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1941)
        at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1845)
        at java.lang.Runtime.loadLibrary0(Runtime.java:870)
        at java.lang.System.loadLibrary(System.java:1122)
        at java.awt.Toolkit$3.run(Toolkit.java:1636)
        at java.awt.Toolkit$3.run(Toolkit.java:1634)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.awt.Toolkit.loadLibraries(Toolkit.java:1633)
        at java.awt.Toolkit.<clinit>(Toolkit.java:1668)
        at java.awt.Cursor.<clinit>(Cursor.java:195)
        at javax.swing.text.html.HTMLEditorKit.<clinit>(HTMLEditorKit.java:623)
        at com.intellij.util.ui.UIUtil.<clinit>(UIUtil.java:102)
        at com.intellij.ide.plugins.PluginManager.start(PluginManager.java:78)
        ... 6 more
Also, an UI exception occurred on attempt to show above message:
java.lang.NoClassDefFoundError: Could not initialize class java.awt.Toolkit
        at java.awt.Component.<clinit>(Component.java:594)
        at com.intellij.idea.Main.showMessage(Main.java:172)
        at com.intellij.idea.Main.showMessage(Main.java:148)
        at com.intellij.idea.Main.main(Main.java:81)

Why are you merging pull requests that do not even pass a simple test?

Mic92 added a commit that referenced this pull request Mar 22, 2018
@Mic92
webstorm: fix incorrect jre usuage
b9b08f8 
it tried to use its own jre, which is not patched

fixes #36943 #37328
@Mic92
Copy link
Member

Mic92 commented Mar 22, 2018

webstorm was fixed in b9b08f8

@averelld averelld deleted the jetbrains-updates branch March 22, 2018 20:06
Mic92 added a commit that referenced this pull request Apr 8, 2018
@Mic92
webstorm: fix incorrect jre usuage
065fd96 
it tried to use its own jre, which is not patched

fixes #36943 #37328

(cherry picked from commit b9b08f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir requested changes

@edwtjo edwtjo edwtjo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@averelld @andir @Mic92 @edwtjo @GrahamcOfBorg