Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shogun: disable parallel building #38488

Merged
merged 1 commit into from Apr 19, 2018
Merged

shogun: disable parallel building #38488

merged 1 commit into from Apr 19, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Apr 5, 2018 •
edited

Motivation for this change

ZHF #36453

Despite a previous attempt to fix parallel building (see #32271), shogun still has sporadic build failures like this that I could not reproduce locally. Looking at the logs, this is likely due to an incorrect build sequence. Disable parallel building for now.

I based this PR on 18.03 because currently liblapack, a dependency of shogun, doesn't build on master. The change should be picked to master later.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
shogun: disable paralllel building
96f5d52 
... to avoid sporadic failures
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: shogun

Partial log (click to expand)

shrinking /nix/store/j7s7zkiplsx7jsnc3l3xfb98hrc71b87-ColPack-1.0.10/examples/Basic/color_graph_using_GraphColoringInterface
shrinking /nix/store/j7s7zkiplsx7jsnc3l3xfb98hrc71b87-ColPack-1.0.10/examples/Basic/color_bipartite_graph_using_BipartiteGraphPartialColoringInterface
shrinking /nix/store/j7s7zkiplsx7jsnc3l3xfb98hrc71b87-ColPack-1.0.10/examples/Basic/color_bipartite_graph_using_BipartiteGraphBicoloringInterface
shrinking /nix/store/j7s7zkiplsx7jsnc3l3xfb98hrc71b87-ColPack-1.0.10/lib/libColPack.so.0.0.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/j7s7zkiplsx7jsnc3l3xfb98hrc71b87-ColPack-1.0.10/lib
patching script interpreter paths in /nix/store/j7s7zkiplsx7jsnc3l3xfb98hrc71b87-ColPack-1.0.10
checking for references to /build in /nix/store/j7s7zkiplsx7jsnc3l3xfb98hrc71b87-ColPack-1.0.10...
cannot build derivation '/nix/store/lkcdciyr6rgkgrg4xvc31m3xi5w940nj-shogun-6.0.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/lkcdciyr6rgkgrg4xvc31m3xi5w940nj-shogun-6.0.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: shogun

Partial log (click to expand)

shrinking /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0/share/shogun/examples/libshogun/streaming_onlineliblinear_sparse
shrinking /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0/share/shogun/examples/libshogun/streaming_stringfeatures
shrinking /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0/share/shogun/examples/libshogun/streaming_vwfeatures
shrinking /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0/share/shogun/examples/libshogun/transfer_multitaskleastsquaresregression
shrinking /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0/share/shogun/examples/libshogun/transfer_multitasklogisticregression
shrinking /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0/share/shogun/examples/libshogun/variational_approx_example
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0/lib
patching script interpreter paths in /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0
checking for references to /build in /nix/store/wr1izv3qadkjqqvqrmcxvcmmkfj432l0-shogun-6.0.0...

@xeji
Copy link
Contributor Author

xeji commented Apr 5, 2018

aarch64 failure is unrelated (a dependency fails)

@matthewbauer matthewbauer merged commit bee6194 into NixOS:release-18.03 Apr 19, 2018
@xeji xeji deleted the p/shogun branch April 19, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @matthewbauer