Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelPatches: Adds bcm2835_mmal_v4l2_camera_driver #38490

Closed
wants to merge 1 commit into from

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Apr 5, 2018

The kernel patch is required for raspberry pi, to enable the camera
module.

Motivation for this change

The patch is only required for raspberry pi, but enabling it for all platforms should not harm anyone.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Apr 8, 2018

Is there a reason to have it on many kernel versions instead of just the latest version? I think this patch will get included upstream in Linux 4.17 anyway.

@bkchr
Copy link
Contributor Author

bkchr commented Apr 8, 2018

Yeah, I wasn't unsure where to add it. I will just add it to the latest kernel.

The kernel patch is required for raspberry pi, to enable the camera
module.
@bkchr
Copy link
Contributor Author

bkchr commented Apr 8, 2018

@dezgeg I changed the patch to apply it only for kernel 4.16 (latest).

@bkchr
Copy link
Contributor Author

bkchr commented Apr 8, 2018

We just need to track, that 4.17 will include the patch by default.

@dezgeg
Copy link
Contributor

dezgeg commented Apr 16, 2018

I amended some comments and pushed as 438631e

@dezgeg dezgeg closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants