Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enumerable#uniq for entry pair #5129

Merged
merged 1 commit into from Apr 12, 2018
Merged

Fix Enumerable#uniq for entry pair #5129

merged 1 commit into from Apr 12, 2018

Conversation

ChrisBr
Copy link
Contributor

@ChrisBr ChrisBr commented Apr 5, 2018 •
edited

The second part of the pair was ignored before which resulted e.g.

class Foo
  include Enumerable
  def each
    yield 1
    yield 1,2
  end
end.new.to_enum.uniq -> [1] instead of [1, [1,2]]

Fixes test/mri/ruby/test_enum.rb#test_uniq test.

@ChrisBr
Fix Enumerable#uniq for entry pair
daa9010 
The second part of the pair was ignored before which resulted e.g.

class Foo
  include Enumerable
  def each
    yield 1
    yield 1,2
  end
end.new.to_enum.uniq -> [1] instead of [1, [1,2]]

Fixes test/mri/ruby/test_enum.rb#test_uniq test.
@headius headius merged commit 82ab6e3 into jruby:master Apr 12, 2018
@headius headius added this to the JRuby 9.2.0.0 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headius headius headius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisBr @headius