Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazonka: fix build after hackage update #38496

Merged
merged 1 commit into from Apr 6, 2018
Merged

Conversation

jerith666
Copy link
Contributor

fixes #38306

Note that this partially resurrects an approach that was abandoned in #6584, so it may or may not be okay. cc @peti, @shlevy, and @fmap.

I got some leads about what direction to flail in from the "Journey into the Haskell NG infrastructure" postings, but I'm definitely still a newbie at the Haskell infrastructure, so might be missing something obvious. :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@shlevy shlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, though it's definitely @peti's call here.

amazonka-test = super.amazonka-test.overrideScope amazonkaOverrides;
in {
inherit amazonka amazonka-core amazonka-test;
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: trailing newline

@peti peti merged commit fac2951 into NixOS:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amazonka-core fails to build after recent hackage update
5 participants