Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraria-server: 1.3.1.1 -> 1.3.5.3 #38503

Merged
merged 1 commit into from Apr 9, 2018
Merged

terraria-server: 1.3.1.1 -> 1.3.5.3 #38503

merged 1 commit into from Apr 9, 2018

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Apr 6, 2018 •
edited

Motivation for this change

You can't play on old terraria servers with modern clients.
It's a real tragedy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Apr 6, 2018

Any chance we could get this cherry picked to 18.03?

@Mic92 Mic92 merged commit 7578dde into NixOS:master Apr 9, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

18.03:

[detached HEAD 61249b5] terraria-server: 1.3.1.1 -> 1.3.5.3
Author: Okina Matara okinan@protonmail.com
Date: Fri Apr 6 02:39:51 2018 -0500
1 file changed, 2 insertions(+), 2 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chiiruno @Mic92 @GrahamcOfBorg @Madouura