Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geogebra: add archive.org link for 5-0-444-0 #37757

Merged
merged 1 commit into from Mar 26, 2018
Merged

geogebra: add archive.org link for 5-0-444-0 #37757

merged 1 commit into from Mar 26, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 25, 2018 •
edited

Motivation for this change

The geogebra package is subject to break as upstream removes versioned
packages from their download server when five new releases are comming.

This is why I had to fix almost monthly the package by bumping the
version (these can be found by running git log --online | grep geogebra:). As the package didn't cause any issues for several months
now I guess that using archive.org seems to be a suitable solution for
now.

/cc @sternenseemann @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
geogebra: add archive.org link for 5-0-444-0
2379cfc 
The `geogebra` package is subject to break as upstream removes versioned
packages from their download server when five new releases are comming.

This is why I had to fix almost monthly the package by bumping the
version (these can be found by running `git log --online | grep
geogebra:`). As the package didn't cause any issues for several months
now I guess that using `archive.org` seems to be a suitable solution for
now.

/cc @sternenseemann @matthewbauer
@Ma27
Copy link
Member Author

Ma27 commented Mar 25, 2018

@volth makes sense. But I guess that I need someone with access to tarballs.nixos.org to implement this accordingly?

@Mic92
Copy link
Member

Mic92 commented Mar 25, 2018

@GrahamcOfBorg build geogebra

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: geogebra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: geogebra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: geogebra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member

Mic92 commented Mar 25, 2018

tarballs are not cached for this package because: hydraPlatforms = [];

@Ma27
Copy link
Member Author

Ma27 commented Mar 25, 2018

true, this has been introduced by 8df7571#diff-bb69272631310093655bbfd118634d07

In the end I'm not sure if we want to create some extra load to our infrastructure for such a small package which just consists of some JARs being unpacked (as stated in the commit message).

As I'm no core member of this project so I'd like to know how you'd proceed here. Use our binary caching and should we keep the archive.org link just in case?

@Ma27
Copy link
Member Author

Ma27 commented Mar 26, 2018

@Mic92 what's your opinion regarding the tarball caching / usage of archive.org? 5-0-444-0 is the oldest versioned tarball on download.geogebra.org, so it's just a matter of time until it will be dropped and people trying to install geogebra will have broken builds.

@Mic92
Copy link
Member

Mic92 commented Mar 26, 2018

Should be ok.

@Mic92 Mic92 merged commit 635b5fc into NixOS:master Mar 26, 2018
@Ma27 Ma27 deleted the add-archive-link-for-geogebra branch March 26, 2018 09:02
@Ma27
Copy link
Member Author

Ma27 commented Mar 26, 2018

great, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @Mic92 @GrahamcOfBorg