nixos/acme: Fix letsencrypt test nginx servernames #37759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmertens
reviewed
Mar 26, 2018
There was a problem hiding this comment.
Lgtm, but @aszlig was also looking at this. I don't know this option but found https://gist.github.com/muhammadghazali/6c2b8c80d5528e3118613746e0041263
|
Is this still needed? |
|
Doesn't look like it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
NixOS test died with:
letsencrypt# [ 37.455263] nginx-pre-start[910]: nginx: [emerg] could not build server_names_hash, you should increase server_names_hash_bucket_size: 32Apparently, nginx defaults it based on the cpu advertised on the system.
Things done
Increased
server_names_hash_bucket_sizeto 64 on the letsencrypt host.I think this is sufficient to fix the issue on 18.03, but something else is also breaking the test on master. This change should be sensible either way.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)