Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepassxc: fix darwin build #37790

Merged
merged 2 commits into from Mar 26, 2018
Merged

keepassxc: fix darwin build #37790

merged 2 commits into from Mar 26, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp mentioned this pull request Mar 25, 2018
Closed
8 tasks
@Mic92
Copy link
Member

Mic92 commented Mar 26, 2018

@GrahamcOfBorg build keepassxc

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: keepassxc

Partial log (click to expand)

shrinking /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1/bin/keepassxc-cli
shrinking /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1/bin/keepassxc
shrinking /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1/lib/keepassxc/libkeepassx-autotype-xcb.so
gzipping man pages under /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1/lib  /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1/bin
patching script interpreter paths in /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1
checking for references to /tmp/nix-build-keepassxc-2.3.1.drv-0 in /nix/store/rbh2vff1kbi6ny1dvkv25vnbd801gysy-keepassxc-2.3.1...
postPatchMkspecs
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: keepassxc

Partial log (click to expand)

shrinking /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1/bin/keepassxc-cli
shrinking /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1/bin/keepassxc-proxy
shrinking /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1/bin/keepassxc
gzipping man pages under /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1/lib  /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1/bin
patching script interpreter paths in /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1
checking for references to /build in /nix/store/5nwnxc9hp1j7dai581hijh80b8acc1i8-keepassxc-2.3.1...
postPatchMkspecs
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: keepassxc

Partial log (click to expand)

-- Installing: /nix/store/0w4lwigg7jlh34cdfanznxws7gf35bw1-keepassxc-2.3.1/Applications/KeePassXC.app/Contents/Resources/translations/keepassx_zh_CN.qm
-- Installing: /nix/store/0w4lwigg7jlh34cdfanznxws7gf35bw1-keepassxc-2.3.1/Applications/KeePassXC.app/Contents/Resources/translations/keepassx_zh_TW.qm
post-installation fixup
gzipping man pages under /nix/store/0w4lwigg7jlh34cdfanznxws7gf35bw1-keepassxc-2.3.1/share/man/
strip is /nix/store/vb6mgjqgd9h11nbv60fvrp1ls9nxck2y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0w4lwigg7jlh34cdfanznxws7gf35bw1-keepassxc-2.3.1/bin
patching script interpreter paths in /nix/store/0w4lwigg7jlh34cdfanznxws7gf35bw1-keepassxc-2.3.1
postPatchMkspecs
postPatchMkspecs
/nix/store/0w4lwigg7jlh34cdfanznxws7gf35bw1-keepassxc-2.3.1

@Mic92 Mic92 merged commit 458ff5a into NixOS:master Mar 26, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 26, 2018

Also backported:

[detached HEAD 58d5602] keepassxc: fix darwin build
Author: Josef Kemetmüller josef.kemetmueller@gmail.com
Date: Sun Mar 25 18:46:28 2018 +0200
1 file changed, 13 insertions(+), 2 deletions(-)
[detached HEAD 0b9fea1] keepassxc: 2.3.0 -> 2.3.1
Author: Josef Kemetmüller josef.kemetmueller@gmail.com
Date: Sun Mar 25 21:55:47 2018 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

@knedlsepp knedlsepp deleted the fix-keepassxc-on-darwin branch March 26, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @Mic92 @GrahamcOfBorg