Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quagga service: fix service and re-enable test #37786

Merged
merged 1 commit into from Apr 17, 2018
Merged

quagga service: fix service and re-enable test #37786

merged 1 commit into from Apr 17, 2018

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Mar 25, 2018

adding quagga to quaggavty
reverting 8a18e1f

Motivation for this change

Fix quagga service

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@woffs
quagga service: fix service and re-enable test
66deb3a 
adding quagga to quaggavty
reverting 8a18e1f
woffs referenced this pull request Mar 25, 2018
@globin
quagga service: disable
8a18e1f
@ryantm
Copy link
Member

ryantm commented Apr 3, 2018

@GrahamcOfBorg test quagga

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.quagga

Partial log (click to expand)

killing router2 (pid 606)
killing client (pid 617)
killing server (pid 628)
vde_switch: vde_switch: vde_switch: EOF on stdin, cleaning up and exitingEOF on stdin, cleaning up and exitingEOF on stdin, cleaning up and exiting


vde_switch: vde_switch: vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not emptyCould not remove ctl dir '/build/vde2.ctl': Directory not empty

Could not remove ctl dir '/build/vde3.ctl': Directory not empty
/nix/store/8im2bvli71d91gqb3f3lr40i3q1dy9w6-vm-test-run-quagga

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.quagga

Partial log (click to expand)

killing router2 (pid 641)
killing router1 (pid 653)
killing client (pid 665)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: vde_switch: vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not emptyCould not remove ctl dir '/build/vde2.ctl': Directory not emptyCould not remove ctl dir '/build/vde3.ctl': Directory not empty


/nix/store/91lgad2wibylj2m01gczk9ncx496mb1l-vm-test-run-quagga

@matthewbauer matthewbauer merged commit 1a1f26a into NixOS:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@woffs @ryantm @GrahamcOfBorg @matthewbauer