Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opal: build with gcc6 #37776

Merged
merged 1 commit into from Mar 25, 2018
Merged

opal: build with gcc6 #37776

merged 1 commit into from Mar 25, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 25, 2018

Motivation for this change

Build on gcc7 failed with error: call of overloaded 'abs(unsigned int)' is ambiguous.
Latest upstream code is from 2013, so let's not spend time patching and use gcc6 for the time being.

/cc ZHF #36453
/cc maintainer @7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
opal: build with gcc6
001db39 
build on gcc7 failed with
"Error: call of overloaded 'abs(unsigned int)' is ambiguous"
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opal

Partial log (click to expand)

shrinking /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/lpc10_ptplugin.so
shrinking /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/silk_ptplugin.so
shrinking /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/g7222_ptplugin.so
shrinking /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/g726_ptplugin.so
shrinking /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10/lib/libopal.so.3.10.10
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10/lib
patching script interpreter paths in /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10
checking for references to /tmp/nix-build-opal-3.10.10.drv-0 in /nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10...
/nix/store/3gazili71lfflsvkwfc3yv7wk9c2inhy-opal-3.10.10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opal

Partial log (click to expand)

shrinking /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/speex_ptplugin.so
shrinking /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/iLBC_ptplugin.so
shrinking /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/gsmamrcodec_ptplugin.so
shrinking /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10/lib/opal-3.10.10/codecs/audio/gsm0610_ptplugin.so
shrinking /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10/lib/libopal.so.3.10.10
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10/lib
patching script interpreter paths in /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10
checking for references to /build in /nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10...
/nix/store/swvfd0bryw5c34rhsflknwj2mxgc8kiy-opal-3.10.10

@7c6f434c 7c6f434c merged commit 6a589de into NixOS:master Mar 25, 2018
@xeji xeji deleted the p/opal branch March 25, 2018 17:43
@xeji xeji mentioned this pull request Mar 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @7c6f434c