tlspool: 20170123 -> 20180227 and fix (for 18.03 release) #37778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build tlspool |
|
@leenaars seen this? |
|
@infinisil, @qknight: excellent, thanks! @infinisil: TLS Pool is an infrastructure component that allows to make working with TLS easier, and that hygienically separates security credentials and running processes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Was failing on hydra (https://hydra.nixos.org/job/nixos/release-18.03/nixpkgs.tlspool.x86_64-linux), so this should be cherry-picked to the 18.03 branch. I updated it, removed unnecessary dependencies and patches that aren't needed anymore. I kept all header files as they were before to keep it backwards compatible. Binaries are now in $out/bin too in addition to $out/sbin (changed in upstream I'm pretty sure). Updated the license too (see https://github.com/arpa2/tlspool/blob/master/LICENSE-DAEMON.MD).
I tested a couple binaries without problems (although I'm not sure what this package even does).
Ping @qknight
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)