Add support for target aarch64-linux-musl #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jirutka really the only way to test it would be to run the spec suite and compile the compiler with a compiled compiler. There used to be an automated tool for generating these but it's out of date :( |
jirutka
force-pushed
the
aarch64-linux-musl
branch
from
0290f49
to
d904dbf
Compare
RX14
reviewed
Mar 25, 2018
spec/std/llvm/aarch64_spec.cr
Outdated
| @@ -6,7 +6,7 @@ LLVM.init_aarch64 | |||
| {% end %} | |||
|
|
|||
| private def abi | |||
| triple = "aarch64-unknown-linux-gnu" | |||
| triple = LLVM.default_target_triple.gsub(/^(.+?)-/, "aarch64-") | |||
There was a problem hiding this comment.
Not 100% on this change, why does it need to happen?
There was a problem hiding this comment.
I’m not sure about it too, but hard-coded aarch64-unknown-linux-gnu is not very useful for testing aarch64 with musl, isn’t it?
There was a problem hiding this comment.
I’ve copied this from:
There was a problem hiding this comment.
I think these specs should be changed to always test all the triples we support... Specs run shouldn't depend on the config of the host.
However, leaving it as-is is fine for now, since there's no difference between the calling convention and struct layout for musl and glibc.
There was a problem hiding this comment.
Okay, I’ve reverted this change.
jirutka
force-pushed
the
aarch64-linux-musl
branch
from
d904dbf
to
c85dc7a
Compare
jirutka
force-pushed
the
aarch64-linux-musl
branch
from
c85dc7a
to
71de1d9
Compare
Does it at least partially work? Where can I find it? |
|
@jirutka There are several, see crystal-lang/crystal_lib, olbat/libgen and TechMagister/bindgencr. |
|
@Sija no, the one specifically used for generating the current bindings was https://github.com/ysbaddaden/posix. But the definition files are incomplete and I never got it to work. It might be able to get you most of the way there though? |
|
@RX14 thx, I had a feeling I missed one from @ysbaddaden. |
|
And it stops on this, even when |
These are just broken tests, the result is correct. These failures are quite expected. |
jirutka
changed the title
|
IIRC iconv is broken on x86 musl too, can you confirm? Is the time related spec due to a missing zonedb? Please submit a patch to wrap the |
jirutka
added a commit
to jirutka/crystal
that referenced
this pull request
Mar 25, 2018
jirutka
added a commit
to jirutka/crystal
that referenced
this pull request
Mar 25, 2018
Yes, the same errors are on x86_64.
Yes, the error is gone after installing tzdata! |
|
Yeah, skip the GB2312 encoding issues. Musl's iconv doesn't support this encoding, and specs have always failed. |
|
@jirutka can you confirm that (with all the PRs and patches):
If so, this is 👍 to me. |
RX14
approved these changes
Mar 25, 2018
ysbaddaden
approved these changes
Mar 26, 2018
sdogruyol
pushed a commit
that referenced
this pull request
Apr 13, 2018
* Fix codegen/asm specs to run x86 ASM only on x86_64 and i686 See #5861 (comment) * Fix codegen/sizeof specs for aarch64 (and other 64bit arches) See #5861 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RX14, could you please verify if it’s correct? Is there some way how to automatically check it or even generate? I’ve done this by hand, comparing existing x86_64-linux-gnu vs. aarch64-linux-gnu and musl arch-specific sources.
Related to #5467