Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst-rtsp-server: Init at 1.12.3 #37780

Merged
merged 2 commits into from Mar 30, 2018
Merged

gst-rtsp-server: Init at 1.12.3 #37780

merged 2 commits into from Mar 30, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Mar 25, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Mar 30, 2018

@GrahamcOfBorg build gst_all_1.gst-rtsp-server

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gst_all_1.gst-rtsp-server

Partial log (click to expand)

strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8b3flh3l8i178j90l9c8w0girmpv26j9-gst-rtsp-server-1.12.3/lib
patching script interpreter paths in /nix/store/8b3flh3l8i178j90l9c8w0girmpv26j9-gst-rtsp-server-1.12.3
checking for references to /tmp/nix-build-gst-rtsp-server-1.12.3.drv-0 in /nix/store/8b3flh3l8i178j90l9c8w0girmpv26j9-gst-rtsp-server-1.12.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/p3p9p648p5rfc0jrm4w0xvb23wqnr33j-gst-rtsp-server-1.12.3-dev
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p3p9p648p5rfc0jrm4w0xvb23wqnr33j-gst-rtsp-server-1.12.3-dev/lib
/nix/store/8b3flh3l8i178j90l9c8w0girmpv26j9-gst-rtsp-server-1.12.3
patching script interpreter paths in /nix/store/p3p9p648p5rfc0jrm4w0xvb23wqnr33j-gst-rtsp-server-1.12.3-dev
checking for references to /tmp/nix-build-gst-rtsp-server-1.12.3.drv-0 in /nix/store/p3p9p648p5rfc0jrm4w0xvb23wqnr33j-gst-rtsp-server-1.12.3-dev...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gst_all_1.gst-rtsp-server

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Patching '/nix/store/q2sdq307rbllajjqqbhwc87npg0y4fjq-gst-rtsp-server-1.12.3-dev/lib/pkgconfig/gstreamer-rtsp-server-1.0.pc' includedir to output /nix/store/q2sdq307rbllajjqqbhwc87npg0y4fjq-gst-rtsp-server-1.12.3-dev
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/y1yjqqpdp55q77cvr5ckvycq2yp0h5am-gst-rtsp-server-1.12.3/lib
patching script interpreter paths in /nix/store/y1yjqqpdp55q77cvr5ckvycq2yp0h5am-gst-rtsp-server-1.12.3
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q2sdq307rbllajjqqbhwc87npg0y4fjq-gst-rtsp-server-1.12.3-dev/lib
patching script interpreter paths in /nix/store/q2sdq307rbllajjqqbhwc87npg0y4fjq-gst-rtsp-server-1.12.3-dev
/nix/store/y1yjqqpdp55q77cvr5ckvycq2yp0h5am-gst-rtsp-server-1.12.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gst_all_1.gst-rtsp-server

Partial log (click to expand)

strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wafb6yklr0k54ix1a4s8sfxss2wg9nzx-gst-rtsp-server-1.12.3/lib
patching script interpreter paths in /nix/store/wafb6yklr0k54ix1a4s8sfxss2wg9nzx-gst-rtsp-server-1.12.3
checking for references to /build in /nix/store/wafb6yklr0k54ix1a4s8sfxss2wg9nzx-gst-rtsp-server-1.12.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/5j2hhzv0yjw4j25wxcy4gr7ffq0lrpb6-gst-rtsp-server-1.12.3-dev
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5j2hhzv0yjw4j25wxcy4gr7ffq0lrpb6-gst-rtsp-server-1.12.3-dev/lib
patching script interpreter paths in /nix/store/5j2hhzv0yjw4j25wxcy4gr7ffq0lrpb6-gst-rtsp-server-1.12.3-dev
checking for references to /build in /nix/store/5j2hhzv0yjw4j25wxcy4gr7ffq0lrpb6-gst-rtsp-server-1.12.3-dev...
/nix/store/wafb6yklr0k54ix1a4s8sfxss2wg9nzx-gst-rtsp-server-1.12.3

@bkchr
Copy link
Contributor Author

bkchr commented Mar 30, 2018

@grahamc will you merge this? :)

grahamc
grahamc reviewed Mar 30, 2018
View reviewed changes
pkgs/development/libraries/gstreamer/rtsp-server/default.nix
a library on top of GStreamer for building an RTSP server.
'';
license = licenses.lgpl2Plus;
platforms = platforms.linux ++ platforms.darwin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add yourself as a maintainer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@grahamc grahamc merged commit 77917ff into NixOS:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @grahamc @GrahamcOfBorg