Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.shell-conduit: fix build #37766

Merged
merged 1 commit into from Mar 25, 2018
Merged

haskellPackages.shell-conduit: fix build #37766

merged 1 commit into from Mar 25, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 25, 2018 •
edited

Motivation for this change

shell-conduit is currently broken, see psibi/shell-conduit#15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (none, it's a library)
  • Fits CONTRIBUTING.md.

This should be cherry-picked into release-18.03 and stable (still at conduit 1.12).

@rnhmjoj rnhmjoj requested a review from peti as a code owner March 25, 2018 13:53
@peti
Copy link
Member

peti commented Mar 25, 2018

@GrahamcOfBorg build haskellPackages.shell-conduit

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.shell-conduit

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

peti
peti reviewed Mar 25, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :-) I'll merge once the test comes back positive.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: haskellPackages.shell-conduit

Partial log (click to expand)

Building test suite 'test' for resourcet-1.1.11..
<command line>: cannot satisfy -package-id hspec-2.4.8-EnFnwh8yhIr2rVLd6Gk2zM:
    hspec-2.4.8-EnFnwh8yhIr2rVLd6Gk2zM is unusable due to shadowed dependencies:
      QuickCheck-2.10.1-4Os66uOJMCzBKiZgTbIvyk hspec-core-2.4.8-KTyycE1zLDkDl64C2ODuq1 hspec-discover-2.4.8-KDtf7WjKY9d2mj17R8fwJF
    (use -v for more information)
builder for '/nix/store/xi5pzd1bfxb6kpgfq6fmaxwxnn2fgk37-resourcet-1.1.11.drv' failed with exit code 1
cannot build derivation '/nix/store/na0jqxrxpp8683668l5flqkcpvfq8chh-conduit-1.2.13.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kabk6mscz0sgmsjx6dnyvidqilwrsny6-conduit-extra-1.2.3.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/qpcm8f3kwmjas3xsaj45prc7k9n1qn97-shell-conduit-4.6.1.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/qpcm8f3kwmjas3xsaj45prc7k9n1qn97-shell-conduit-4.6.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.shell-conduit

Partial log (click to expand)

shrinking /nix/store/d5a51sx8byck6xgb2vznrga3j1pwsnaa-shell-conduit-4.6.1/lib/ghc-8.2.2/x86_64-linux-ghc-8.2.2/libHSshell-conduit-4.6.1-HSSsESeFmbGLWwFG9VC6eh-ghc8.2.2.so
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/d5a51sx8byck6xgb2vznrga3j1pwsnaa-shell-conduit-4.6.1/lib
patching script interpreter paths in /nix/store/d5a51sx8byck6xgb2vznrga3j1pwsnaa-shell-conduit-4.6.1
checking for references to /build in /nix/store/d5a51sx8byck6xgb2vznrga3j1pwsnaa-shell-conduit-4.6.1...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/hjp4cwwydpnv5i87jw9jrwwm6jwfym3w-shell-conduit-4.6.1-doc
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/hjp4cwwydpnv5i87jw9jrwwm6jwfym3w-shell-conduit-4.6.1-doc
checking for references to /build in /nix/store/hjp4cwwydpnv5i87jw9jrwwm6jwfym3w-shell-conduit-4.6.1-doc...

@peti peti merged commit 53ab595 into NixOS:master Mar 25, 2018
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 25, 2018

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti left review comments

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @peti @GrahamcOfBorg