Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptlib: fix build #37772

Merged
merged 1 commit into from
Mar 25, 2018
Merged

ptlib: fix build #37772

merged 1 commit into from
Mar 25, 2018
+7 −3

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 25, 2018

Motivation for this change

Didn't build with unixODBC>=2.3.5 due to typedef clashes.
Fix these and remove an obsolete patch.

/cc ZHF #36453
/cc maintainer @7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@xeji
ptlib: fix build

Verified

This commit was signed with the committer’s verified signature. The key has expired.
suvash Suvash Thapaliya
GPG key ID: BB8D4E7B4156AAA6
Expired
Verified
Learn about vigilant mode
4308403 
patch typedef clashes with unixODBC>=2.3.5
@7c6f434c
Copy link
Member

@GrahamcOfBorg biuld ptlib sipcmd

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 25, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ptlib

Partial log (click to expand)

shrinking /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11/lib/ptlib-2.10.11/devices/videoinput/v4l2_pwplugin.so
shrinking /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11/lib/ptlib-2.10.11/devices/sound/pulse_pwplugin.so
shrinking /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11/lib/ptlib-2.10.11/devices/sound/alsa_pwplugin.so
shrinking /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11/lib/libpt.so.2.10.11
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11/lib  /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11/bin
patching script interpreter paths in /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11
/nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11/share/ptlib/make/ptlib-config: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11...
/nix/store/5xcrx7xrszcg95fxlas5cm78g13ri5gf-ptlib-2.10.11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ptlib

Partial log (click to expand)

shrinking /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11/lib/ptlib-2.10.11/devices/videoinput/v4l2_pwplugin.so
shrinking /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11/lib/ptlib-2.10.11/devices/sound/alsa_pwplugin.so
shrinking /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11/lib/ptlib-2.10.11/devices/sound/pulse_pwplugin.so
shrinking /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11/lib/libpt.so.2.10.11
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11/lib  /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11/bin
patching script interpreter paths in /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11
/nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11/share/ptlib/make/ptlib-config: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11...
/nix/store/bn5w7ppsawxy57j7r33rrcgcx7rjmj9k-ptlib-2.10.11

@xeji
Copy link
Contributor Author

xeji commented Mar 25, 2018

@GrahamcOfBorg build opal

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: opal

Partial log (click to expand)

     int lmax;
         ^~~~
make[3]: Leaving directory '/build/opal-3.10.10/plugins/video/H.263-1998'
make[2]: *** [Makefile:6: all] Error 2
make[2]: Leaving directory '/build/opal-3.10.10/plugins'
make[1]: *** [Makefile:578: subdirs] Error 2
make[1]: Leaving directory '/build/opal-3.10.10'
make: *** [Makefile:728: opt] Error 2
builder for '/nix/store/7n735rzayixks51zbdhzhwnm9cxc5mwy-opal-3.10.10.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/7n735rzayixks51zbdhzhwnm9cxc5mwy-opal-3.10.10.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: opal

Partial log (click to expand)

make[3]: *** [/build/opal-3.10.10/plugins/plugin-inc.mak:67: /build/opal-3.10.10/plugins/../lib_linux_x86_64/plugins/h263_ffmpeg/mpi.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/build/opal-3.10.10/plugins/video/H.263-1998'
make[2]: *** [Makefile:6: all] Error 2
make[2]: Leaving directory '/build/opal-3.10.10/plugins'
make[1]: *** [Makefile:578: subdirs] Error 2
make[1]: Leaving directory '/build/opal-3.10.10'
make: *** [Makefile:728: opt] Error 2
builder for '/nix/store/avc8wi5jh2ypdj9x22rjqdqxryihaig7-opal-3.10.10.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/avc8wi5jh2ypdj9x22rjqdqxryihaig7-opal-3.10.10.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Mar 25, 2018 •
edited
Loading

@7c6f434c opal build failure due to error: call of overloaded 'abs(unsigned int)' is ambiguous is a typical gcc7 symptom, looks unrelated to ptlib. Just checking if it builds with gcc6.
Edit: opal builds with gcc6, and then sipcmd succeeds as well.

@7c6f434c 7c6f434c merged commit e124e20 into NixOS:master Mar 25, 2018
@xeji xeji deleted the p/ptlib branch March 25, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @7c6f434c @GrahamcOfBorg