Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome2.gtksourceview: fix build on Darwin #37775

Merged
merged 1 commit into from Mar 25, 2018
Merged

gnome2.gtksourceview: fix build on Darwin #37775

merged 1 commit into from Mar 25, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 25, 2018

Motivation for this change

Build failure on darwin:

  CCLD     libgtksourceview-2.0.la
Undefined symbols for architecture x86_64:
  "_libintl_bind_textdomain_codeset", referenced from:
      __gtksourceview_gettext in gtksourceview-i18n.o
  "_libintl_bindtextdomain", referenced from:
      __gtksourceview_gettext in gtksourceview-i18n.o
  "_libintl_dgettext", referenced from:
      __gtksourceview_dgettext in gtksourceview-i18n.o
ld: symbol(s) not found for architecture x86_64
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl vbgl added 0.kind: bug 6.topic: darwin Running or building packages on Darwin labels Mar 25, 2018
@7c6f434c
Copy link
Member

@GrahamcOfBorg build gnome2.gtksourceview

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome2.gtksourceview

Partial log (click to expand)

post-installation fixup
Removing /nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5/share/gtk-doc
rmdir: failed to remove '/nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5
shrinking /nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5/lib/libgtksourceview-2.0.so.0.0.0
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5/lib
patching script interpreter paths in /nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5
checking for references to /build in /nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5...
/nix/store/bb3sqvw2sa70j2i9nnvidpp0ir1g3963-gtksourceview-2.10.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gnome2.gtksourceview

Partial log (click to expand)

/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5/lib/libgtksourceview-2.0.0.dylib: fixing dylib
/nix/store/lndp8bl4v06kfgxggmgdvnkkhs86xdbm-gtksourceview-2.10.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnome2.gtksourceview

Partial log (click to expand)

post-installation fixup
Removing /nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5/share/gtk-doc
rmdir: failed to remove '/nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5
shrinking /nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5/lib/libgtksourceview-2.0.so.0.0.0
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5/lib
patching script interpreter paths in /nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5
checking for references to /build in /nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5...
/nix/store/f2gkzd829f4j30pyvjmyi4cr82dhw1yw-gtksourceview-2.10.5

@7c6f434c 7c6f434c merged commit 762e238 into NixOS:master Mar 25, 2018
@vbgl vbgl deleted the gtksourceview-2-darwin branch March 27, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: bug 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @7c6f434c @GrahamcOfBorg