Improve OSX bit rot #6695
Merged
Improve OSX bit rot #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiles and runs for me on macOS 10.12.6. I'm not competent to review the changes. I could try and trigger specific issues that the commits address if that helps. |
frosch123
reviewed
Apr 9, 2018
src/fontdetection.cpp
Outdated
|
|
||
| /* Get a file system reference for the font. */ | ||
| FSRef ref; | ||
| /* Get font reference from name. */ |
frosch123
reviewed
Apr 9, 2018
src/fontdetection.cpp
Outdated
| CFStringRef name = CFStringCreateWithCString(kCFAllocatorDefault, font_name, kCFStringEncodingUTF8); | ||
|
|
||
| #if (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_6) | ||
| if (MacOSVersionIsAtLeast(10, 6, 0)) { |
frosch123
reviewed
Apr 9, 2018
src/fontdetection.cpp
Outdated
| CFRelease(fontURL); | ||
| } | ||
| if (descs != NULL) CFRelease(descs); | ||
| } else |
michicc
force-pushed
the
osx_api_refresh
branch
from
697ef11
to
1372a00
Compare
|
Now with less spaces :) |
michicc
force-pushed
the
osx_api_refresh
branch
from
1372a00
to
d184b72
Compare
|
Exterminate all the spaces! |
TrueBrain
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSX APIs are an ever-moving target. Update some uses in OTTD to hopefully improve compatibility with newer OSX versions.