Commits on Apr 8, 2018

1. Increase max group name length to 32 characters …

   With #36556, a check was introduced to make sure the user and group
   names do not exceed their respective maximum length. This is in part
   because systemd also enforces that length, but only at runtime.
   
   So in general it's a good idea to catch as much as we can during
   evaluation time, however the maximum length of the group name was set to
   16 characters according groupadd(8).
   
   The maximum length of the group names however is a compile-time option
   and even systemd allows more than 16 characters. In the mentioned pull
   request (#36556) there was already a report that this has broken
   evaluation for people out there.
   
   I have also checked what other distributions are doing and they set the
   length to either 31 characters or 32 characters, the latter being more
   common.
   
   Unfortunately there is a difference between the maximum length enforced
   by the shadow package and systemd, both for user name lengths and group
   name lengths. However, systemd enforces both length to have a maximum of
   31 characters and I'm not sure if this is intended or just a off-by-one
   error in systemd.
   
   Nevertheless, I choose 32 characters simply to bring it in par with the
   maximum user name length.
   
   For the NixOS assertion however, I use a maximum length of 31 to make
   sure that nobody accidentally creates services that contain group names
   that systemd considers invalid because of a length of 32 characters.
   
   Signed-off-by: aszlig <aszlig@nix.build>
   Closes: #38548
   Cc: @vcunat, @fpletz, @qknight

   

   aszlig committed Apr 8, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 99ba1cb
   • Browse repository at this point

   Copy the full SHA

   99ba1cb View commit details

   Browse the repository at this point in the history