Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomacs: 3.6.1 -> 3.8.1 #38576

Merged
merged 1 commit into from Apr 8, 2018
Merged

nomacs: 3.6.1 -> 3.8.1 #38576

merged 1 commit into from Apr 8, 2018

Conversation

ahmedtd
Copy link
Contributor

@ahmedtd ahmedtd commented Apr 7, 2018 •
edited

Fixes a build issue introduced by a Qt5 upgrade [1], and lets us drop
our installation-path patch.

[1] nomacs/nomacs#203

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ahmedtd
nomacs: 3.6.1 -> 3.8.1
642bd5f 
Fixes a build issue introduced by a Qt5 upgrade [1], and lets us drop
our installation-path patch.

[1] nomacs/nomacs#203
@Mic92 Mic92 merged commit 811ff3f into NixOS:master Apr 8, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018

18.03:

[detached HEAD 6c36186] nomacs: 3.6.1 -> 3.8.1
Author: Taahir Ahmed ahmed.taahir@gmail.com
Date: Sat Apr 7 15:09:35 2018 -0700
2 files changed, 2 insertions(+), 17 deletions(-)
delete mode 100644 pkgs/applications/graphics/nomacs/fix-appdata-install.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedtd @Mic92 @GrahamcOfBorg