doc: overrides hljs overflow rules for better linking.
#206
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `overflow-x` rule applied is a good idea, except that it makes it impossible (without JavaScript) to link to the right location with anchor links, which are heavily used, especially with callouts. The `overflow-x` being set to `visible` did not cause any issues beforehand, AFAIK.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the
pre'soverflow-xtovisible, which is the initial value, which is overridden by the newhljsdependency. Anchor links inside boxes with anoverfloworpositionset cannot account for the top navbar's height in the first 80px of an element, this is a limitation of how CSS works. This could be worked-around using JavaScript (I think), but the previous behaviour did not cause any issues AFAIK.Before
After clicking on
(1)After
After clicking on
(1)