flash: Fix end address for firmware. #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash.py
Outdated
| @@ -41,12 +41,12 @@ def main(): | |||
| filename = make.get_firmware(builddir, "flash") | |||
|
|
|||
| address_start = platform.gateware_size + make.BIOS_SIZE | |||
| address_end = platform.gateware_size | |||
| address_end = platform.spiflash_total_size | |||
|
|
|||
| elif args.mode == 'other': | |||
| filename = args.other | |||
There was a problem hiding this comment.
Thanks a lot for insta-correcting this!
I think this should read filename = args.other_file
|
Thanks @FelixHenninger ! I'll merge this change now! |
|
Awesome, thanks a lot! I'm super-glad to have helped a tiny bit -- I'll need to find some free time to catch up to master, and then I've got a few more little things I could contribute (though they might have to go upstream to |
|
Please do reach out if you need help. Improving support for the nexys_video is something I definitely support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425.