Add TLAPS and TLA+ Toolbox #38589
Merged
Add TLAPS and TLA+ Toolbox #38589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 8, 2018
| Terminal=false | ||
| Name=TLA Toolbox | ||
| Categories=Application;Development; | ||
| StartupWMClass=TLA+ Toolbox |
There was a problem hiding this comment.
For desktop items we usually use this:
There was a problem hiding this comment.
ooh that's useful. I'll do that. Thanks for the pointer!
Mic92
reviewed
Apr 10, 2018
| ''; | ||
| homepage = https://tla.msr-inria.inria.fr/tlaps/content/Home.html; | ||
| license = stdenv.lib.licenses.bsd2; | ||
| platforms = stdenv.lib.platforms.unix; |
There was a problem hiding this comment.
Do you want to maintain this package? https://nixos.wiki/wiki/Nixpkgs#Becoming_a_Nixpkgs_maintainer
There was a problem hiding this comment.
sure, sounds fun :)
Mic92
reviewed
Apr 10, 2018
| ''; | ||
| # http://lamport.azurewebsites.net/tla/license.html | ||
| license = with lib.licenses; [ mit ]; | ||
| platforms = stdenv.lib.platforms.linux; |
Mic92
reviewed
Apr 10, 2018
| , makeWrapper | ||
| , stdenv | ||
| , ocaml, gawk, isabelle, cvc3, perl, wget, which | ||
| , ... |
Mic92
reviewed
Apr 10, 2018
| @@ -0,0 +1,80 @@ | |||
| { lib, fetchzip, makeWrapper, makeDesktopItem, stdenv, jre, swt, gtk, libXtst, glib | |||
| , ... }: | |||
Mic92
reviewed
Apr 10, 2018
|
|
||
| chmod +x $out/bin/tla-toolbox | ||
|
|
||
| wrapProgram "$out/bin/tla-toolbox" \ |
There was a problem hiding this comment.
if you use makeWrapper, you don't need the echo above. It also has a --run parameter for the cd command and --add-flags for arguments.
There was a problem hiding this comment.
Thanks for pointing that out!
Adapted to use makeWrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This attempts to address #18640.
Testing:
tlaplusToolbox: I've been using this without unexpected issues (pdf generation needspdflatexin thePATH).tlaps: Bothtlapmandzenonrun and produce their usage information.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)